You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/25 21:16:47 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #7536: [AIRFLOW-6918]
don't use 'is' in if conditions comparing STATE
tooptoop4 opened a new pull request #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 closed pull request #7536: [AIRFLOW-6918] don't
use 'is' in if conditions comparing STATE
Posted by GitBox <gi...@apache.org>.
tooptoop4 closed pull request #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #7536: [AIRFLOW-6918] don't
use 'is' in if conditions comparing STATE
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536#issuecomment-591107895
@kaxil updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #7536: [AIRFLOW-6918] don't
use 'is' in if conditions comparing STATE
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536#issuecomment-592000630
@feluelle any idea why travis unhappy? maybe the current code (before my PR) was always evaluating to false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7536: [AIRFLOW-6918] don't use
'is' in if conditions comparing STATE
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536#issuecomment-591097807
The PR and JIRA has no description, please add it before someone can review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7536: [AIRFLOW-6918] don't
use 'is' in if conditions comparing STATE
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7536: [AIRFLOW-6918] don't use 'is' in if conditions comparing STATE
URL: https://github.com/apache/airflow/pull/7536#issuecomment-592005586
Can you try a rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services