You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/04/15 17:26:48 UTC

Review Request 33222: DRILL-2292: CTAS broken when we have repeated maps

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33222/
-----------------------------------------------------------

Review request for drill, Hanifi Gunes and Steven Phillips.


Bugs: DRILL-2292
    https://issues.apache.org/jira/browse/DRILL-2292


Repository: drill-git


Description
-------

- fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is negative or _NO_VALUES_
- added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java aa98818 
  exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java PRE-CREATION 
  exec/java-exec/src/test/resources/parquet/2292.json PRE-CREATION 

Diff: https://reviews.apache.org/r/33222/diff/


Testing
-------

all unit tests are passing along with regression, customer and tpch100


Thanks,

abdelhakim deneche

Re: Review Request 33222: DRILL-2292: CTAS broken when we have repeated maps

Posted by Hanifi Gunes <ha...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33222/#review80841
-----------------------------------------------------------


Looks pretty. Almost there.


exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
<https://reviews.apache.org/r/33222/#comment130946>

    We should consider moving this *super call* down the check.



exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
<https://reviews.apache.org/r/33222/#comment130948>

    the same.



exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java
<https://reviews.apache.org/r/33222/#comment130949>

    As /tmp is platform dependent, you may want to use nio.Files#createTempFile or Guava's equivalent. We should get rid of *getRandomTableName*.



exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java
<https://reviews.apache.org/r/33222/#comment130951>

    The data file seems RM in MAP in RM. Perhaps we should keep this and add another test case for RM in RM.


- Hanifi Gunes


On April 20, 2015, 9:48 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33222/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 9:48 p.m.)
> 
> 
> Review request for drill, Hanifi Gunes and Steven Phillips.
> 
> 
> Bugs: DRILL-2292
>     https://issues.apache.org/jira/browse/DRILL-2292
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is negative or _NO_VALUES_
> - added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java 767c366 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java 71a5017 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rl_in_rl.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rl_in_rm.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_in_rl.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_in_rm.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33222/diff/
> 
> 
> Testing
> -------
> 
> all unit tests are passing along with regression, customer and tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>

Re: Review Request 33222: DRILL-2292: CTAS broken when we have repeated maps

Posted by Hanifi Gunes <ha...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33222/#review81258
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java
<https://reviews.apache.org/r/33222/#comment131549>

    we should not need this.


- Hanifi Gunes


On April 21, 2015, 4:14 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33222/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 4:14 p.m.)
> 
> 
> Review request for drill, Hanifi Gunes and Steven Phillips.
> 
> 
> Bugs: DRILL-2292
>     https://issues.apache.org/jira/browse/DRILL-2292
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> - fixed _RepeatedMapReaderImpl.setPosition()_ to handle when the index is negative or _NO_VALUES_
> - added unit test _TestRepeatedReaders.testReadNestedRepeatedMap()_
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java 767c366 
>   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java 71a5017 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestRepeatedReaders.java PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rl_rl.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rl_rm.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_m_rm.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_rl.json PRE-CREATION 
>   exec/java-exec/src/test/resources/parquet/2292.rm_rm.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33222/diff/
> 
> 
> Testing
> -------
> 
> one final round of testing, I will update the results of the tests once they are done
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>