You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2023/06/29 02:37:44 UTC

[GitHub] [echarts] Ovilia commented on a diff in pull request #18820: feat(pie): add angleRange for control pie range

Ovilia commented on code in PR #18820:
URL: https://github.com/apache/echarts/pull/18820#discussion_r1246024785


##########
src/chart/pie/PieSeries.ts:
##########
@@ -112,6 +112,7 @@ export interface PieSeriesOption extends
 
     clockwise?: boolean
     startAngle?: number
+    angleRange?: number

Review Comment:
   Although I do think `angleRange` may be easier to be understood than `endAngle`, we still need to comply with currect option of [gauge.endAngle](https://echarts.apache.org/zh/option.html#series-gauge.endAngle).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org