You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2024/05/29 07:57:55 UTC
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Hello Marton Greber, Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21466
to review the following change.
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Update build pattern for fetching flaky tests list
During the infra changes which happened in the last months, the build_id
prefix has been changed [note 1]. As a result flaky tests are not
retried during testing in the pre-commit runs. This patch updates the
build pattern in the build-and-test.sh script, such that the
list of flaky tests is fetched correctly.
[note 1]:
The build_id of an isolated test is constructed with Jenkins job's name
and build number, prefixed with "jenkins-". To illustrate this let me
give some examples, for build_ids prior and after the infra upgrade.
Before:
jenkins-kudu-gerrit-BUILD_TYPE=ASAN-29232
jenkins-kudu-gerrit-BUILD_TYPE=DEBUG-29227
After:
jenkins-build_and_test-64
jenkins-build_and_test-63
From the above we can see that the new Jenkins job name caused the
issue. The new job is parametrised, does not contain the build type in
the job's name. Therefore, a change in the naming is justified.
In case something like this happens in the future, the build_ids can be
observed in the test_results MySQL database on the isolateserver test
infra host.
Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Reviewed-on: http://gerrit.cloudera.org:8080/21327
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 7b5fc9f2f0ad538242656431bf76e253cc537772)
---
M build-support/jenkins/build-and-test.sh
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/21466/1
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2024 08:02:43 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Update build pattern for fetching flaky tests list
During the infra changes which happened in the last months, the build_id
prefix has been changed [note 1]. As a result flaky tests are not
retried during testing in the pre-commit runs. This patch updates the
build pattern in the build-and-test.sh script, such that the
list of flaky tests is fetched correctly.
[note 1]:
The build_id of an isolated test is constructed with Jenkins job's name
and build number, prefixed with "jenkins-". To illustrate this let me
give some examples, for build_ids prior and after the infra upgrade.
Before:
jenkins-kudu-gerrit-BUILD_TYPE=ASAN-29232
jenkins-kudu-gerrit-BUILD_TYPE=DEBUG-29227
After:
jenkins-build_and_test-64
jenkins-build_and_test-63
From the above we can see that the new Jenkins job name caused the
issue. The new job is parametrised, does not contain the build type in
the job's name. Therefore, a change in the naming is justified.
In case something like this happens in the future, the build_ids can be
observed in the test_results MySQL database on the isolateserver test
infra host.
Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Reviewed-on: http://gerrit.cloudera.org:8080/21327
Reviewed-by: Ashwani Raina <ar...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 7b5fc9f2f0ad538242656431bf76e253cc537772)
Reviewed-on: http://gerrit.cloudera.org:8080/21466
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Tested-by: Attila Bukor <ab...@apache.org>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved
Ashwani Raina: Looks good to me, but someone else must approve
Zoltan Chovan: Looks good to me, but someone else must approve
Attila Bukor: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2024 08:39:46 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 May 2024 10:27:29 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/185/
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 29 May 2024 07:58:01 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Patch Set 1:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/185/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 May 2024 19:58:02 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) Update build pattern for fetching flaky tests list
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21466 )
Change subject: Update build pattern for fetching flaky tests list
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Gerrit-Change-Number: 21466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 May 2024 08:57:22 +0000
Gerrit-HasComments: No