[GitHub] [airflow] sunank200 commented on a diff in pull request #31866: Decode old Xcom value from airflow 2.5.2

["sunank200 (via GitHub)" <gi...@apache.org>]

sunank200 commented on code in PR #31866:
URL: https://github.com/apache/airflow/pull/31866#discussion_r1227666783


##########
airflow/serialization/serde.py:
##########
@@ -276,7 +276,10 @@ def deserialize(o: T | None, full=True, type_hint: Any = None) -> object:
 def _convert(old: dict) -> dict:
     """Converts an old style serialization to new style."""
     if OLD_TYPE in old and OLD_DATA in old:
-        return {CLASSNAME: old[OLD_TYPE], VERSION: DEFAULT_VERSION, DATA: old[OLD_DATA][OLD_DATA]}
+        if old[OLD_TYPE] == "dict":

Review Comment:
   I think adding a comment here why we are comparing with `dict` would help



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org