You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/05/09 01:33:13 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #541: [YUNIKORN-1719] Improve the performance of Application.sortRequests()
pbacsko opened a new pull request, #541:
URL: https://github.com/apache/yunikorn-core/pull/541
### What is this PR for?
Use `btree.BTree` to store allocation requests, so we don't have to call `Application.sortRequests()` constantly.
Iteration occurs through `BTree.Ascend()`, allocation logic is passed as a function.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1719
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #541: [YUNIKORN-1719] Improve the performance of Application.sortRequests()
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #541: [YUNIKORN-1719] Improve the performance of Application.sortRequests()
URL: https://github.com/apache/yunikorn-core/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #541: [YUNIKORN-1719] Improve the performance of Application.sortRequests()
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #541:
URL: https://github.com/apache/yunikorn-core/pull/541#issuecomment-1539269652
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#541](https://app.codecov.io/gh/apache/yunikorn-core/pull/541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (514bebe) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/8664ce2b584c41fbfe3ea4aa41634d48214295d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8664ce2) will **increase** coverage by `0.00%`.
> The diff coverage is `78.37%`.
```diff
@@ Coverage Diff @@
## master #541 +/- ##
=======================================
Coverage 75.06% 75.07%
=======================================
Files 70 70
Lines 11332 11388 +56
=======================================
+ Hits 8506 8549 +43
- Misses 2529 2539 +10
- Partials 297 300 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `64.87% <77.14%> (+0.45%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation\_ask.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb25fYXNrLmdv) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on pull request #541: [YUNIKORN-1719] Improve the performance of Application.sortRequests()
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #541:
URL: https://github.com/apache/yunikorn-core/pull/541#issuecomment-1555052456
Closed in favor of #547.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org