You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2019/12/05 02:27:09 UTC

[james-project] 07/07: JAMES-2952 Solve various warnings within SieveExecutor

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 38d06ee0581bfe2d13cd5b06bbd30692bbc038c7
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Wed Dec 4 08:53:11 2019 +0700

    JAMES-2952 Solve various warnings within SieveExecutor
---
 .../james/transport/mailets/jsieve/delivery/SieveExecutor.java    | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java
index a06999a..d86cba0 100644
--- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java
+++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java
@@ -20,8 +20,6 @@
 
 package org.apache.james.transport.mailets.jsieve.delivery;
 
-import java.io.IOException;
-
 import javax.mail.MessagingException;
 
 import org.apache.commons.logging.Log;
@@ -124,7 +122,7 @@ public class SieveExecutor {
         return !isSieveNotification ? sieveMessage(recipient, mail) : false;
     }
 
-    protected boolean sieveMessage(MailAddress recipient, Mail aMail) throws MessagingException {
+    private boolean sieveMessage(MailAddress recipient, Mail aMail) {
         try {
             ResourceLocator.UserSieveInformation userSieveInformation = resourceLocator.get(recipient);
             sieveMessageEvaluate(recipient, aMail, userSieveInformation);
@@ -138,7 +136,7 @@ public class SieveExecutor {
         }
     }
 
-    private void sieveMessageEvaluate(MailAddress recipient, Mail aMail, ResourceLocator.UserSieveInformation userSieveInformation) throws MessagingException, IOException {
+    private void sieveMessageEvaluate(MailAddress recipient, Mail aMail, ResourceLocator.UserSieveInformation userSieveInformation) throws MessagingException {
         try {
             SieveMailAdapter aMailAdapter = new SieveMailAdapter(aMail,
                 mailetContext, actionDispatcher, sievePoster, userSieveInformation.getScriptActivationDate(),
@@ -156,7 +154,7 @@ public class SieveExecutor {
     }
 
     @VisibleForTesting
-    void handleFailure(MailAddress recipient, Mail aMail, Exception ex) throws MessagingException, IOException {
+    void handleFailure(MailAddress recipient, Mail aMail, Exception ex) throws MessagingException {
         MailImpl errorMail = MailImpl.builder()
             .name(MailImpl.getId())
             .addAttribute(new Attribute(SIEVE_NOTIFICATION, AttributeValue.of(true)))


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org