You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/04/28 02:18:00 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #6707: BugFix: MIOBuffer created in lazzy ways, may not has IOBufferBlock #6702

maskit commented on a change in pull request #6707:
URL: https://github.com/apache/trafficserver/pull/6707#discussion_r416277174



##########
File path: proxy/http/HttpSM.cc
##########
@@ -1907,6 +1907,12 @@ HttpSM::state_read_server_response_header(int event, void *data)
   case VC_EVENT_EOS:
     server_entry->eos = true;
 
+    if (vio->ndone == 0) {

Review comment:
       This part is probably correct, but there is a similar code below.
   https://github.com/apache/trafficserver/blob/e8bb4909bc2c948250ba860a71b8a08f853a4275/proxy/http/HttpSM.cc#L1993-L1994
   
   How about make this parse error and handle it later on the line?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org