[GitHub] [inlong] gong commented on a diff in pull request #7517: [INLONG-7516][Manager][Sort][Agent] Decoupling Flink version dependencies for multiple versions of Apache Flink

["gong (via GitHub)" <gi...@apache.org>]

gong commented on code in PR #7517:
URL: https://github.com/apache/inlong/pull/7517#discussion_r1133528899


##########
inlong-sort/pom.xml:
##########
@@ -80,6 +83,17 @@
                 <artifactId>kudu-client</artifactId>
                 <version>${kudu.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-shaded-jackson</artifactId>
+                <version>${flink.jackson.version}</version>
+            </dependency>
+            <!--ojdbc8 is FUTC license, we use it test only-->
+            <dependency>
+                <groupId>com.oracle.database.jdbc</groupId>
+                <artifactId>ojdbc8</artifactId>
+                <version>${oracle.jdbc.version}</version>
+            </dependency>

Review Comment:
   It need add <scope>test</scope> ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org