You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/21 03:36:49 UTC

[GitHub] [druid] kfaraz commented on a diff in pull request #13130: Web console: add append to existing callout

kfaraz commented on code in PR #13130:
URL: https://github.com/apache/druid/pull/13130#discussion_r976002950


##########
web-console/src/views/load-data-view/info-messages.tsx:
##########
@@ -216,3 +217,48 @@ export const SpecMessage = React.memo(function SpecMessage() {
     </FormGroup>
   );
 });
+
+export interface AppendToExistingIssueProps {
+  spec: Partial<IngestionSpec>;
+  onChangeSpec(newSpec: Partial<IngestionSpec>): void;
+}
+
+export const AppendToExistingIssue = React.memo(function AppendToExistingIssue(

Review Comment:
   Nit: Do we want to call it `AppendToExistingIssue`?
   To me, `issue` implies that there is a known bug and we are yet to fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org