You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (JIRA)" <ji...@apache.org> on 2016/05/26 14:02:12 UTC

[jira] [Commented] (FLINK-3978) Add contains methods to RuntimeContext

    [ https://issues.apache.org/jira/browse/FLINK-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302101#comment-15302101 ] 

Aljoscha Krettek commented on FLINK-3978:
-----------------------------------------

For the accumulators, I think the way to go is what is proposed as part of this: https://issues.apache.org/jira/browse/FLINK-3758, i.e. change the accumulator interface to allow getting an accumulator or adding a new one in one method call.

> Add contains methods to RuntimeContext
> --------------------------------------
>
>                 Key: FLINK-3978
>                 URL: https://issues.apache.org/jira/browse/FLINK-3978
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The javadocs for `RuntimeContext` state that `getAccumulator` "throws an exception if the accumulator does not exist or if the accumulator exists, but with different type", although `AbstractRuntimeUDFContext` does not throw an exception but will return null.
> The javadocs for `getBroadcastVariable` do not mention throwing an exception. Currently the only way to handle a broadcast variable that that may or may not exist is to catch and ignore the exception. Adding a  `containsBroadcastVariable` method to `RuntimeContext` would make this explicit. Likewise, `containsAccumulator`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)