You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/15 07:19:34 UTC
[GitHub] [incubator-doris] xinyiZzz opened a new pull request, #10156: [fix] (mem tracker) Refactor memtable mem tracker, fix flush memtable DCHECK failed
xinyiZzz opened a new pull request, #10156:
URL: https://github.com/apache/incubator-doris/pull/10156
# Proposed changes
Issue Number: close #10154
## Problem Summary:
1. Added memory leak detection for `DeltaWriter` and `MemTable` mem tracker, instead of `DCECK(mem_consumption() > _mem_table->memory_usage())` in `DeltaWriter` flush memtable. Avoid being affected by mem tracker consumption order.
2. Modify memtable mem tracker to virtual to avoid frequent recursive consumption of parent tracker.
3. Attach load mem tracker when flushing memtable to ensure that memtable mem tracker is completely accurate.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10156: [fix] (mem tracker) Refactor memtable mem tracker, fix flush memtable DCHECK failed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10156:
URL: https://github.com/apache/incubator-doris/pull/10156#issuecomment-1156158093
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #10156: [fix] (mem tracker) Refactor memtable mem tracker, fix flush memtable DCHECK failed
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #10156:
URL: https://github.com/apache/incubator-doris/pull/10156#issuecomment-1156729436
@dataroaring fix be ut, PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10156: [fix] (mem tracker) Refactor memtable mem tracker, fix flush memtable DCHECK failed
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10156:
URL: https://github.com/apache/doris/pull/10156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10156: [fix] (mem tracker) Refactor memtable mem tracker, fix flush memtable DCHECK failed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10156:
URL: https://github.com/apache/incubator-doris/pull/10156#issuecomment-1156158137
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10156: [fix] (mem tracker) Refactor memtable mem tracker, fix flush memtable DCHECK failed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10156:
URL: https://github.com/apache/doris/pull/10156#issuecomment-1159658243
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org