You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2021/03/12 17:29:52 UTC
[kudu-CR] [master] Remove FLAGS master consensus allow status msg for failed peer
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17180
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
......................................................................
[master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
FLAGS_master_consensus_allow_status_msg_for_failed_peer goes
hand-in-hand with FLAGS_master_support_change_config
so removing it and using the common FLAGS_master_support_change_config
instead.
This reduces the need for additional validation when orchestrating
the add master flow.
Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
3 files changed, 10 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17180/1
--
To view, visit http://gerrit.cloudera.org:8080/17180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Gerrit-Change-Number: 17180
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [master] Remove FLAGS master consensus allow status msg for failed peer
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17180
to look at the new patch set (#3).
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
......................................................................
[master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
FLAGS_master_consensus_allow_status_msg_for_failed_peer goes
hand-in-hand with FLAGS_master_support_change_config
so removing it and using the common FLAGS_master_support_change_config
instead.
This reduces the need for additional validation when orchestrating
the add master flow.
Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
3 files changed, 11 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/17180/3
--
To view, visit http://gerrit.cloudera.org:8080/17180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Gerrit-Change-Number: 17180
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] Remove FLAGS master consensus allow status msg for failed peer
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17180 )
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:
http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc@98
PS2, Line 98: false
> Are we comfortable enough with this flag to set it to true? What more do we
Once we have the orchestration tool checked-in we can flip this flag and remove the hidden tag as well.
http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc@101
PS2, Line 101: TAG_FLAG(master_support_change_config, advanced);
> Should this be labeled 'advanced'? What's unsafe about it?
advanced is more accurate.
--
To view, visit http://gerrit.cloudera.org:8080/17180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Gerrit-Change-Number: 17180
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 31 Mar 2021 18:01:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master] Remove FLAGS master consensus allow status msg for failed peer
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17180 )
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:
http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc@98
PS2, Line 98: false
Are we comfortable enough with this flag to set it to true? What more do we need to do?
http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc@101
PS2, Line 101: TAG_FLAG(master_support_change_config, unsafe);
Should this be labeled 'advanced'? What's unsafe about it?
--
To view, visit http://gerrit.cloudera.org:8080/17180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Gerrit-Change-Number: 17180
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 29 Mar 2021 19:35:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master] Remove FLAGS master consensus allow status msg for failed peer
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17180 )
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Gerrit-Change-Number: 17180
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 31 Mar 2021 18:26:48 +0000
Gerrit-HasComments: No
[kudu-CR] [master] Remove FLAGS master consensus allow status msg for failed peer
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17180 )
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
......................................................................
[master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer
FLAGS_master_consensus_allow_status_msg_for_failed_peer goes
hand-in-hand with FLAGS_master_support_change_config
so removing it and using the common FLAGS_master_support_change_config
instead.
This reduces the need for additional validation when orchestrating
the add master flow.
Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Reviewed-on: http://gerrit.cloudera.org:8080/17180
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/master/sys_catalog.cc
3 files changed, 11 insertions(+), 17 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f
Gerrit-Change-Number: 17180
Gerrit-PatchSet: 4
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)