You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "gaoxinge (GitHub)" <gi...@apache.org> on 2020/02/27 03:59:27 UTC

[GitHub] [dubbo-go] gaoxinge opened pull request #377: Format

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

- add blank between functions

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->

- None

**Special notes for your reviewer**:

- None

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
None
```

[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #377: Format

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=h1) Report
> Merging [#377](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4e67732d0b8047a0ebb2e356c1ed9135f4a5642d?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/377/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #377      +/-   ##
===========================================
+ Coverage    66.59%   66.74%   +0.14%     
===========================================
  Files          150      157       +7     
  Lines         7964     8239     +275     
===========================================
+ Hits          5304     5499     +195     
- Misses        2156     2214      +58     
- Partials       504      526      +22
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <ø> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <ø> (ø)` | :arrow_up: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.14% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <ø> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <ø> (ø)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `95.87% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | :arrow_up: |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <ø> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | :arrow_up: |
| ... and [27 more](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=footer). Last update [4e67732...231b256](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #377: Format

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=h1) Report
> Merging [#377](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4e67732d0b8047a0ebb2e356c1ed9135f4a5642d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/377/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree)

```diff
@@           Coverage Diff            @@
##           develop     #377   +/-   ##
========================================
  Coverage    66.59%   66.59%           
========================================
  Files          150      150           
  Lines         7964     7964           
========================================
  Hits          5304     5304           
  Misses        2156     2156           
  Partials       504      504
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <ø> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <ø> (ø)` | :arrow_up: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.14% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <ø> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <ø> (ø)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `95.87% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | :arrow_up: |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <ø> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=footer). Last update [4e67732...6f28487](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx closed pull request #377: Format

Posted by "zouyx (GitHub)" <gi...@apache.org>.
[ pull request closed by zouyx ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #377: Format

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=h1) Report
> Merging [#377](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4e67732d0b8047a0ebb2e356c1ed9135f4a5642d?src=pr&el=desc) will **increase** coverage by `0.52%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/377/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #377      +/-   ##
===========================================
+ Coverage    66.59%   67.11%   +0.52%     
===========================================
  Files          150      157       +7     
  Lines         7964     8239     +275     
===========================================
+ Hits          5304     5530     +226     
- Misses        2156     2186      +30     
- Partials       504      523      +19
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <ø> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <ø> (ø)` | :arrow_up: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.14% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <ø> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <ø> (ø)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `95.87% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | :arrow_up: |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <ø> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | :arrow_up: |
| ... and [32 more](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=footer). Last update [4e67732...231b256](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #377: Format

Posted by "zouyx (GitHub)" <gi...@apache.org>.
```suggestion
	returnProtocols :=make([]*ProtocolConfig,0,len(protocols))
```
Specify the capacity and length is better

[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #377: Format

Posted by "zouyx (GitHub)" <gi...@apache.org>.
As above

[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #377: Format

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=h1) Report
> Merging [#377](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4e67732d0b8047a0ebb2e356c1ed9135f4a5642d?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/377/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #377      +/-   ##
===========================================
+ Coverage    66.59%   66.74%   +0.14%     
===========================================
  Files          150      157       +7     
  Lines         7964     8239     +275     
===========================================
+ Hits          5304     5499     +195     
- Misses        2156     2214      +58     
- Partials       504      526      +22
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <ø> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `71.15% <ø> (ø)` | :arrow_up: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.14% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | :arrow_up: |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <ø> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.44% <ø> (ø)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `95.87% <ø> (ø)` | :arrow_up: |
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | :arrow_up: |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.96% <ø> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | :arrow_up: |
| ... and [27 more](https://codecov.io/gh/apache/dubbo-go/pull/377/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=footer). Last update [4e67732...231b256](https://codecov.io/gh/apache/dubbo-go/pull/377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] gaoxinge commented on pull request #377: Format

Posted by "gaoxinge (GitHub)" <gi...@apache.org>.
Nice advice. I specify the capacity when initializing slice.

[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #377: Format

Posted by "zouyx (GitHub)" <gi...@apache.org>.
help change to english comment ,thank you.

[ Full content available at: https://github.com/apache/dubbo-go/pull/377 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org