You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2014/10/02 03:43:48 UTC
Review Request 26256: MESOS-1857 Fix path::join() on older libstdc++
which lack back()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26256/
-----------------------------------------------------------
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1857
https://issues.apache.org/jira/browse/MESOS-1857
Repository: mesos-git
Description
-------
Hand calculate / retrieve the last character rather than using back()
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 63433ef62fd3d8c14a049d09d510571f45e56095
Diff: https://reviews.apache.org/r/26256/diff/
Testing
-------
make check on gcc 4.8.2
Thanks,
Cody Maloney
Re: Review Request 26256: MESOS-1857 Fix path::join() on older
libstdc++ which lack back()
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26256/#review55198
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26256]
All tests passed.
- Mesos ReviewBot
On Oct. 2, 2014, 1:43 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26256/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 1:43 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1857
> https://issues.apache.org/jira/browse/MESOS-1857
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hand calculate / retrieve the last character rather than using back()
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 63433ef62fd3d8c14a049d09d510571f45e56095
>
> Diff: https://reviews.apache.org/r/26256/diff/
>
>
> Testing
> -------
>
> make check on gcc 4.8.2
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 26256: MESOS-1857 Fix path::join() on older
libstdc++ which lack back()
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26256/#review55219
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 2, 2014, 1:43 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26256/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 1:43 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1857
> https://issues.apache.org/jira/browse/MESOS-1857
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hand calculate / retrieve the last character rather than using back()
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 63433ef62fd3d8c14a049d09d510571f45e56095
>
> Diff: https://reviews.apache.org/r/26256/diff/
>
>
> Testing
> -------
>
> make check on gcc 4.8.2
>
>
> Thanks,
>
> Cody Maloney
>
>