You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/03 18:06:49 UTC
[GitHub] [spark] nchammas opened a new pull request #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
nchammas opened a new pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114
### What changes were proposed in this pull request?
This PR adds some rules that will be used by Probot Auto Labeler to label PRs based on what paths they modify.
### Why are the changes needed?
This should make it easier for committers to organize PRs, and it could also help drive downstream tooling like the PR dashboard.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
We'll only be able to test it, I believe, after merging it in. Given that [the Avro project is using this same bot already](https://github.com/apache/avro/blob/master/.github/autolabeler.yml), I expect it will be straightforward to get this working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611982983
**[Test build #121081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121081/testReport)** for PR 28114 at commit [`aadea31`](https://github.com/apache/spark/commit/aadea310f856f00dbee961a929acc0a98d2468ff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608586828
**[Test build #120786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120786/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608586828
**[Test build #120786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120786/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612035652
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121081/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612341587
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121114/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612332946
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121113/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612332740
**[Test build #121113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121113/testReport)** for PR 28114 at commit [`7db3491`](https://github.com/apache/spark/commit/7db3491ef5e8f4997a1420686eb6c28c41b208af).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611983329
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612312813
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612059360
**[Test build #121082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121082/testReport)** for PR 28114 at commit [`8228cf4`](https://github.com/apache/spark/commit/8228cf412faea0c3f53abe9aaa3e7c6cf0e22c89).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611984985
**[Test build #121082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121082/testReport)** for PR 28114 at commit [`8228cf4`](https://github.com/apache/spark/commit/8228cf412faea0c3f53abe9aaa3e7c6cf0e22c89).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406803419
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
Review comment:
I don't think these `!` lines will do what you want.
From https://git-scm.com/docs/gitignore#_pattern_format:
> It is not possible to re-include a file if a parent directory of that file is excluded.
But we can try it out and see what happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981399
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25770/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611983329
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611985256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25772/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608584735
I took a stab at the rules, but I'm sure y'all will want to make a bunch of changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612703505
I am going to merge this now. This is a morning in my time so will probably be able to take a following-up action quick.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610671287
Just to be clear, can you share more specific examples of where you think manual labeling would work better than automatic labeling? What would be the modified paths for a PR that you think automatic labeling wouldn't handle well?
Regarding a better commit history, if automatic labeling works well, we could update the merge script to include the labels in the commit message. Then it becomes one less thing that contributors and committers have to worry about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610794199
I'm kind of agree that we'd better distinguish `sql` and `structured streaming` if possible.
Is it possible to use a regex path, something like `*/streaming/*`(https://git-scm.com/docs/gitignore#_pattern_format) to catch streaming related module?
And as for #24990, I have no idea why we using `state` instead of `streaming`. But since it should be a corner case, I think we could just update this `yml` here whenever needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612341585
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612311716
`DStreams` is `DStream` I believe. And I checked the commit history roughly and `Optimizer`, `Scheduler` and `Shuffle` tend to be just `Core`. For `Security`, we can't tell which directory.
I added `Windows` and `Web UI`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612041979
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121080/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981099
**[Test build #121080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121080/testReport)** for PR 28114 at commit [`84d0c32`](https://github.com/apache/spark/commit/84d0c327c4222a10284ed70a1e056c3766799244).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609556485
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610676495
Please find "STRUCTURED STREAMING" labels in Spark PR.
https://github.com/apache/spark/pulls?q=is%3Aopen+is%3Apr+label%3A%22STRUCTURED+STREAMING%22
If we simply label that `/sql/` becomes SQL, PRs for structured streaming will just be labelled as "SQL", which is the one having the most of PRs, and being hidden by SQL PRs. If we try to label it via capturing the path `streaming/` then we would have to differentiate with DStream.
There's some other case where path doesn't work: #24990 - while it proposes to "add" batch data source, it's to read the state in "structured streaming", which I think labelling to "structured streaming" is correct, whereas path based labelling would label to "SQL".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612317766
**[Test build #121115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121115/testReport)** for PR 28114 at commit [`2ddde69`](https://github.com/apache/spark/commit/2ddde694c13f006d8bbb66bccd015497c53283d2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610841397
> And as for #24990, I have no idea why we using state instead of streaming.
I'm sorry but I don't get it. Could you please elaborate what you meant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612341231
**[Test build #121114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121114/testReport)** for PR 28114 at commit [`30a09c5`](https://github.com/apache/spark/commit/30a09c5eedaa2923bc221014c305922228fffb04).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406714586
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
Review comment:
We should probably exclude `github_jira_sync.py`, `merge_spark_pr.py`, `run-tests-jenkins` and `run-tests-jenkins.py` in BUILD and include them in INFRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364440
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612315528
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406807521
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - "/external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume*"
+ - "/external/kinesis*"
+ - "/external/kafka*"
+ - "/python/pyspark/streaming"
+GRAPHX:
+ - "/graphx/"
+ - "/data/graphx"
+ML:
+ - "ml/"
+ - "/python/pyspark/ml"
+MLLIB:
+ - "spark/mllib/"
+ - "/mllib-local"
+ - "/python/pyspark/mllib"
+STRUCTURED STREAMING:
Review comment:
Do we not need a plain `STREAMING` tag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609524728
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609524728
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612311716
`DStreams` is `DStream` I believe. And I checked the commit history roughly and `Optimizer` tends to be just `SQL`, and `Scheduler` and `Shuffle` tend to be just `Core`. For `Security`, we can't tell which directory.
I added `Windows` and `Web UI`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612312815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25801/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611342090
> I just think without any background there that if the datasource is for streaming, why we don't add streaming as part of package name?
The datasource will run in "batch query", though the input data is from "streaming query".
I might have to reiterate; please don't get me wrong. I don't object the feature, I said it's huge one step forward. I just want to point out that we require manual label for module in the PR title and it's kinda accurate (otherwise committer would fix it) so it seems redundant to do classification here unless we also do automate on PR title. Yes that might require another implementation of bot hence I'm not strong about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608630464
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25528/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612034855
**[Test build #121081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121081/testReport)** for PR 28114 at commit [`aadea31`](https://github.com/apache/spark/commit/aadea310f856f00dbee961a929acc0a98d2468ff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25528/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612703597
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608587452
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25485/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406806383
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - "/external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume*"
+ - "/external/kinesis*"
+ - "/external/kafka*"
+ - "/python/pyspark/streaming"
+GRAPHX:
+ - "/graphx/"
+ - "/data/graphx"
+ML:
+ - "ml/"
+ - "/python/pyspark/ml"
+MLLIB:
+ - "spark/mllib/"
+ - "/mllib-local"
+ - "/python/pyspark/mllib"
Review comment:
We can collapse both this line and L91 into a single rule, `mllib/`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609523731
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612317766
**[Test build #121115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121115/testReport)** for PR 28114 at commit [`2ddde69`](https://github.com/apache/spark/commit/2ddde694c13f006d8bbb66bccd015497c53283d2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611983126
@dongjoon-hyun do you have any concern or comments on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611496937
I will make some changes soon. We could discuss further after that change happens. Labeling both SQL and structure streaming or streaming should be fine. We can't 100% correctly label here.
Current labeling isn't correct already because it relies on the tags in JIRA which can have mistakes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610676495
Please find "STRUCTURED STREAMING" labels in Spark PR.
https://github.com/apache/spark/pulls?q=is%3Aopen+is%3Apr+label%3A%22STRUCTURED+STREAMING%22
If we simply label that `/sql/` becomes SQL, PRs for structured streaming will just be labelled as "SQL", which is the one having the most of PRs, being hidden by SQL PRs. If we try to label it via capturing the path "streaming/" then we would have to differentiate with DStream.
There's some other case where path doesn't work: #24990 - while it proposes to "add" batch data source, it's to read the state in "structured streaming", which I think labelling to "structured streaming" is correct, whereas path based labelling would label to "SQL".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612316754
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612041979
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121080/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364135
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610667025
Thanks for the proposal and the work you've been done!
While I think this is huge one step forward, there's still some difference compared to the manual labelling, as manual labelling considers the module - like "Structured Streaming" which would be simply "SQL" from auto labelling and very hard to filter from SQL PRs.
IMHO, if it's not hard to have our own auto labeler, following the marker for module representation (`[CORE]` or `[SQL]` or so) in PR title would work simpler if the auto labeler can update the label when the PR title has been changed. Reviewers would correct the marker if it's incorrect, not only for labelling but also for better commit history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611424209
For me, github label is easier to use than searching with `[...]` and it's even more accurate (that means, github search is not perfect). If I remember correctly, maintainers can see how many PRs are labelled as label X, which could help to determine the status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610406875
> I will skim the project and refine the list here, and directly add some commits in your PR by pushing them into your branch in your Spark fork if you don't mind.
No problem. Go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612312518
**[Test build #121113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121113/testReport)** for PR 28114 at commit [`7db3491`](https://github.com/apache/spark/commit/7db3491ef5e8f4997a1420686eb6c28c41b208af).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612336757
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121115/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612060371
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121082/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612060371
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121082/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611982983
**[Test build #121081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121081/testReport)** for PR 28114 at commit [`aadea31`](https://github.com/apache/spark/commit/aadea310f856f00dbee961a929acc0a98d2468ff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612315531
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25802/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406705508
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
Review comment:
Okay, I pushed some more changes. I double checked manually by eyes but I didn't really run this plugin by myself. @nchammas can you double check the list please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981099
**[Test build #121080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121080/testReport)** for PR 28114 at commit [`84d0c32`](https://github.com/apache/spark/commit/84d0c327c4222a10284ed70a1e056c3766799244).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612332942
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612316761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25803/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612041971
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611985254
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609524732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25546/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406974034
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
Review comment:
Oh, actually this way is from `node-ignore` package which the plugin uses. Hopefully it works..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981055
@HeartSaVioR, @Ngone51 while you guys are here, can you double check the list too in particular where you guys are familiar with?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610736606
Labels are additive. That is, a single PR can be tagged with multiple labels. Here's an example from the Avro project, which is using the same bot we are proposing to add in this PR: https://github.com/apache/avro/pull/847
And you can filter PRs by combinations of labels. For example:
* `is:open is:pr label:SQL label:streaming` will search for PRs labeled both `SQL` and `streaming`.
* `is:open is:pr label:SQL -label:streaming` will search for PRs labeled `SQL` but _not_ `streaming`.
Does that address part of your concern?
With regards to #24990, is there a pattern we could potentially add to the rule for the `streaming` label so that that PR would be labeled correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364440
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610667025
Thanks for the proposal and the work you've been done!
While I think this is huge one step forward, there's still some difference compared to the manual labelling, as manual labelling considers the module - like "Structured Streaming" which would be simply "SQL" for auto labelling and very hard to filter from SQL PRs.
IMHO, if it's not hard to have our own auto labeler, following the marker for module representation (`[CORE]` or `[SQL]` or so) in PR title would work simpler if the auto labeler can update the label when the PR title has been changed. Reviewers would correct the marker if it's incorrect, not only for labelling but also for better commit history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610985531
> Is it possible to use a regex path, something like `*/streaming/*` (https://git-scm.com/docs/gitignore#_pattern_format) to catch streaming related module?
`streaming/` will pick up directories named `streaming` anywhere in the directory hierarchy. You don't need the asterisks.
The problem that @HeartSaVioR is pointing out is that some PRs we would consider Structured Streaming PRs don't touch paths that are clearly identifiable as Structured Streaming and not just plain SQL.
By the way @HeartSaVioR, some of the files in #24990, like `StateSchemaExtractor.scala`, look like they are just for Structured Streaming, so we could add those to the matching rules for the `streaming` label. It's not a great solution, but it should cover some additional cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406708946
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - /external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume/"
+ - "/external/flume-assembly/"
+ - "/external/flume-sink/"
+ - "/external/kinesis-asl/"
+ - "/external/kinesis-asl-assembly/"
+ - "/external/kafka-0-10/"
+ - "/external/kafka-0-10-assembly/"
Review comment:
We could change this something like `/external/kafka*`, `/external/kinesis*` to make it shorter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406805941
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
Review comment:
I suppose we don't technically need this line since the rule above, `sql/`, will catch all directories named `sql`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612312815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25801/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612315531
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25802/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612312518
**[Test build #121113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121113/testReport)** for PR 28114 at commit [`7db3491`](https://github.com/apache/spark/commit/7db3491ef5e8f4997a1420686eb6c28c41b208af).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612312813
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612703505
I am going to merge this now. This is morning in my time so will probably be able to take a following-up action quick.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612316574
**[Test build #121114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121114/testReport)** for PR 28114 at commit [`30a09c5`](https://github.com/apache/spark/commit/30a09c5eedaa2923bc221014c305922228fffb04).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611983332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25771/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609524483
**[Test build #120852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120852/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612311716
`DStreams` is `DStream` I believe. And I checked the commit history roughly and `Optimizer` tends to be just `SQL, and`Scheduler` and `Shuffle` tend to be just `Core`. For `Security`, we can't tell which directory.
I added `Windows` and `Web UI`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406708946
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - /external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume/"
+ - "/external/flume-assembly/"
+ - "/external/flume-sink/"
+ - "/external/kinesis-asl/"
+ - "/external/kinesis-asl-assembly/"
+ - "/external/kafka-0-10/"
+ - "/external/kafka-0-10-assembly/"
Review comment:
We could change this something like `/external/kafka*/`, `/external/kinesis*/` to make it shorter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611779055
And I was wrong - anyone can see how many issues and PRs are open under such label, which is even better.
https://github.com/apache/spark/labels
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609369509
**[Test build #120829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120829/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612336757
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121115/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612316754
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608630464
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609524483
**[Test build #120852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120852/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981391
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609523887
> This PR seems the approach is based on the directory the changes include, which I think it's fine at this moment.
The automatic labelling based on PR changes looks nice to me. Btw, thanks for the great work, @nchammas !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608630091
**[Test build #120786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120786/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r404836296
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+
+infra:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+build:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+release:
+ - "/dev/create-release/"
+docs:
+ - "docs/"
+ - "examples/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+core:
+ - "/core/"
+sql:
+ - "sql/"
+ml:
+ - "ml/"
+ - "mllib/"
+ - "mllib-local/"
+streaming:
+ - "streaming/"
+python:
+ - "python/"
+java:
+ - "/common/"
+ - "java/"
+R:
+ - "r/"
Review comment:
`/r/` will only match `r/` at the root of the project. `r/` will match a directory named `r` anywhere in the folder hierarchy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608587446
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609369588
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120829/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612035640
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609523887
> This PR seems the approach is based on the directory the changes include, which I think it's fine at this moment.
The automatic labelling based on the updates looks nice to me. Btw, thanks for the great work, @nchammas !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406706806
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
Review comment:
BTW, the tags here are same as JIRA components. There's one exception `Documentation` which should be usually `DOCS` per the contribution guide (the tag in the PR title).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364220
Currently the labels are being mapped with the ones set in the JIRA. This PR seems the approach is based on the directory the changes include, which I think it's fine at this moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364142
WDYT @dongjoon-hyun ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612332942
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612776959
Okay .. seems finally started to work. Seems so far as good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r407012944
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+ - "/dev/github_jira_sync.py"
+ - "/dev/merge_spark_pr.py"
+ - "/dev/run-tests-jenkins*"
+BUILD:
+ - "/dev/"
+ - "!/dev/github_jira_sync.py"
+ - "!/dev/merge_spark_pr.py"
+ - "!/dev/run-tests-jenkins*"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore/"
+ - "/common/network-common/"
+ - "/common/network-shuffle/"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl/"
+SQL:
+ - "sql/"
+ - "/common/unsafe/"
+ - "!/python/pyspark/sql/avro/"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+ - "*SQL*.R"
Review comment:
I was hesitant about adding R with SQL here because we don't usually label R with SQL in these files probably because RDD APIs are private in R. However, I concluded that there's no harm to label `SQL` at least for consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608630473
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120786/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612035640
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611406758
@HeartSaVioR I see. And yeah, this recall me my feeling when I first time saw the github label. It's really kind of duplicate with manual label. And I have been already used to manual label compares to github label. And it's fact that our github label is really not noticeable with low-key color.
I don't know why we introduce github label firstly..maybe for better history searching or something else? cc @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612316574
**[Test build #121114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121114/testReport)** for PR 28114 at commit [`30a09c5`](https://github.com/apache/spark/commit/30a09c5eedaa2923bc221014c305922228fffb04).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612315528
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610754650
Yeah as I said it's still one huge step forward and it's still great to get this in as it is. I'm just saying there're some cases which need classification by human, and we always have been doing the classification per PR.
> With regards to #24990, is there a pattern we could potentially add to the rule for the streaming label so that that PR would be labeled correctly?
I guess not, as the case is the counter case where path based auto labelling won't work. It still needs the "human being" to classify, and auto labeler just needs to reflect the classification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612035652
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121081/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r407009652
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - "/external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume*"
+ - "/external/kinesis*"
+ - "/external/kafka*"
+ - "/python/pyspark/streaming"
+GRAPHX:
+ - "/graphx/"
+ - "/data/graphx"
+ML:
+ - "ml/"
+ - "/python/pyspark/ml"
+MLLIB:
+ - "spark/mllib/"
+ - "/mllib-local"
+ - "/python/pyspark/mllib"
Review comment:
Actually, I think we shouldn't collapse to `mllib/` because `/mllib/` contains both ML and MLlib.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406805131
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
Review comment:
I don't think we can exclude files if we have a matching rule on the parent directory, per my other review comment on `!`. But at the very least we can add these files to `INFRA` and they will be tagged both `BUILD` and `INFRA`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612336611
**[Test build #121115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121115/testReport)** for PR 28114 at commit [`2ddde69`](https://github.com/apache/spark/commit/2ddde694c13f006d8bbb66bccd015497c53283d2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609556485
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611984985
**[Test build #121082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121082/testReport)** for PR 28114 at commit [`8228cf4`](https://github.com/apache/spark/commit/8228cf412faea0c3f53abe9aaa3e7c6cf0e22c89).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r407010945
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
Review comment:
Let's see if it works or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612316761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25803/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609369586
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608587446
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609556491
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120852/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612336750
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612060364
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612341587
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121114/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608587452
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25485/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612060364
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612336750
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609369586
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612554731
I'll merge this PR in few days to try out. Let me know if you guys have any concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r407012944
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,131 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+ - "/dev/github_jira_sync.py"
+ - "/dev/merge_spark_pr.py"
+ - "/dev/run-tests-jenkins*"
+BUILD:
+ - "/dev/"
+ - "!/dev/github_jira_sync.py"
+ - "!/dev/merge_spark_pr.py"
+ - "!/dev/run-tests-jenkins*"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore/"
+ - "/common/network-common/"
+ - "/common/network-shuffle/"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl/"
+SQL:
+ - "sql/"
+ - "/common/unsafe/"
+ - "!/python/pyspark/sql/avro/"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+ - "*SQL*.R"
Review comment:
I was hesitant about adding R with SQL here because we don't usually label R with SQL in these files probably because RDD APIs are private in R. However, I concluded that there's no harm to label `SQL`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611342090
> I just think without any background there that if the datasource is for streaming, why we don't add streaming as part of package name?
The datasource will run in "batch query", though the input data is from "streaming query".
I might have to reiterate; please don't get me wrong. I don't object the feature, I said it's huge one step forward. I just wanted to point out that we require manual label for module in the PR title and it's kinda accurate (otherwise committer would fix it) so it seems redundant to do classification here unless we also do automate on PR title. (If we are confident about the classification then why not?) Yes that might require another implementation of bot hence I'm not strong about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609555961
**[Test build #120852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120852/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612332946
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121113/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406807521
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - "/external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume*"
+ - "/external/kinesis*"
+ - "/external/kafka*"
+ - "/python/pyspark/streaming"
+GRAPHX:
+ - "/graphx/"
+ - "/data/graphx"
+ML:
+ - "ml/"
+ - "/python/pyspark/ml"
+MLLIB:
+ - "spark/mllib/"
+ - "/mllib-local"
+ - "/python/pyspark/mllib"
+STRUCTURED STREAMING:
Review comment:
Do we not need a plain `STREAMING` tag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406974515
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - "/external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume*"
+ - "/external/kinesis*"
+ - "/external/kafka*"
+ - "/python/pyspark/streaming"
+GRAPHX:
+ - "/graphx/"
+ - "/data/graphx"
+ML:
+ - "ml/"
+ - "/python/pyspark/ml"
+MLLIB:
+ - "spark/mllib/"
+ - "/mllib-local"
+ - "/python/pyspark/mllib"
Review comment:
Yeah, let me add another commit. Feel free to edit @nchammas meanwhile :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610676495
Please find "STRUCTURED STREAMING" labels in Spark PR.
https://github.com/apache/spark/pulls?q=is%3Aopen+is%3Apr+label%3A%22STRUCTURED+STREAMING%22
If we simply label that `/sql/` becomes SQL, PRs for structured streaming will just be labelled as "SQL", which is the one having the most of PRs, being hidden by SQL PRs. If we try to label it via capturing the path "streaming" then we would have to differentiate with DStream.
There's some other case where path doesn't work: #24990 - while it proposes to "add" batch data source, it's to read the state in "structured streaming", which I think labelling to "structured streaming" is correct, whereas path based labelling would label to "SQL".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609524732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25546/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981391
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406801210
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
Review comment:
Is `/repl` equivalent to `/repl/`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-608630473
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120786/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r406708503
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+# Also, note that the plugin uses 'ignore' package. See also
+# https://github.com/kaelzhang/node-ignore
+INFRA:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+ - "/dev/create-release/"
+ - ".asf.yaml"
+ - ".gitattributes"
+ - ".gitignore"
+BUILD:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+ - "/assembly/"
+ - "*pom.xml"
+ - "/bin/docker-image-tool.sh"
+ - "/bin/find-spark-home*"
+ - "scalastyle-config.xml"
+DOCS:
+ - "docs/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+EXAMPLES:
+ - "examples/"
+ - "/bin/run-example*"
+CORE:
+ - "/core/"
+ - "/common/kvstore"
+ - "/common/network-common"
+ - "/common/network-shuffle"
+ - "/python/pyspark/*.py"
+ - "/python/pyspark/tests/*.py"
+ - "/sbin/*master*.sh"
+ - "/sbin/*slave*.sh"
+ - "/sbin/spark-config.sh"
+ - "/sbin/*daemon*.sh"
+ - "/sbin/*history*.sh"
+ - "/sbin/*mesos*.sh"
+SPARK SUBMIT:
+ - "/bin/spark-submit*"
+SPARK SHELL:
+ - "/repl"
+SQL:
+ - "sql/"
+ - "/common/unsafe"
+ - "/python/pyspark/sql"
+ - "!/python/pyspark/sql/avro"
+ - "!/python/pyspark/sql/streaming.py"
+ - "!/python/pyspark/sql/tests/test_streaming.py"
+ - "/bin/spark-sql*"
+ - "/bin/beeline*"
+ - "/sbin/*thriftserver*.sh"
+AVRO:
+ - /external/avro"
+ - "/python/pyspark/sql/avro"
+DSTREAM:
+ - "/streaming/"
+ - "/data/streaming"
+ - "/external/flume/"
+ - "/external/flume-assembly/"
+ - "/external/flume-sink/"
+ - "/external/kinesis-asl/"
+ - "/external/kinesis-asl-assembly/"
+ - "/external/kafka-0-10/"
+ - "/external/kafka-0-10-assembly/"
+ - "/python/pyspark/streaming"
+GRAPHX:
+ - "/graphx/"
+ - "/data/graphx"
+ML:
+ - "ml/"
+ - "/python/pyspark/ml"
+MLLIB:
+ - "spark/mllib/"
+ - "/mllib-local"
+ - "/python/pyspark/mllib"
+STRUCTURED STREAMING:
+ - "sql/**/streaming/"
+ - "/external/kafka-0-10-sql/"
+ - "/python/pyspark/sql/streaming.py"
+ - "/python/pyspark/sql/tests/test_streaming.py"
+PYTHON:
+ - "/bin/pyspark*"
+ - "python/"
+R:
+ - "r/"
+ - "R/"
Review comment:
According to https://github.com/kaelzhang/node-ignore#optionsignorecase-since-400 which the [plugin uses](https://github.com/mithro/autolabeler/blob/master/index.js#L22), seems it's case-insensitive by default but I just kept it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612341585
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612536327
Looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611277086
> I'm sorry but I don't get it. Could you please elaborate what you meant?
I just think without any background there that if the datasource is for streaming, why we don't add `streaming` as part of package name?
But since it's a corner case, can't we just update `yml` file here to catch the future change? I guess `yml` file won't be frequently updated since most of cases have already been included by the current file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611981399
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25770/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611985256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25772/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610676495
Please find "STRUCTURED STREAMING" labels in Spark PR.
https://github.com/apache/spark/pulls?q=is%3Aopen+is%3Apr+label%3A%22STRUCTURED+STREAMING%22
If we simply label that `/sql/` becomes SQL, PRs for structured streaming will just be labelled as "SQL", which is the one having the most of PRs, being hidden by SQL PRs. If we try to label it via capturing the path `streaming/` then we would have to differentiate with DStream.
There's some other case where path doesn't work: #24990 - while it proposes to "add" batch data source, it's to read the state in "structured streaming", which I think labelling to "structured streaming" is correct, whereas path based labelling would label to "SQL".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611424209
For me, github label is easier to use than searching with `[...]` and it's even more accurate (that means, github search is not perfect). If I remember correctly, maintainers can see how many PRs are labelled as label X, which could help to determine the overall status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r404553040
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+
+infra:
+ - ".github/"
+ - "appveyor.yml"
+ - "/tools/"
+build:
+ - "/dev/"
+ - "/build/"
+ - "/project/"
+release:
+ - "/dev/create-release/"
+docs:
+ - "docs/"
+ - "examples/"
+ - "/README.md"
+ - "/CONTRIBUTING.md"
+core:
+ - "/core/"
+sql:
+ - "sql/"
+ml:
+ - "ml/"
+ - "mllib/"
+ - "mllib-local/"
+streaming:
+ - "streaming/"
+python:
+ - "python/"
+java:
+ - "/common/"
+ - "java/"
+R:
+ - "r/"
Review comment:
It think we should also add `/r/` because some files like `sql/core/src/main/scala/org/apache/spark/sql/api/r/`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612040704
**[Test build #121080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121080/testReport)** for PR 28114 at commit [`84d0c32`](https://github.com/apache/spark/commit/84d0c327c4222a10284ed70a1e056c3766799244).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-612041971
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nchammas commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
nchammas commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r404835318
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+
+infra:
Review comment:
Sure, if that's what you want, it's fine my me. (Though I do find uppercase tags to be "shouty".)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611985254
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609369588
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120829/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#discussion_r404552167
##########
File path: .github/autolabeler.yml
##########
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Bot page: https://github.com/apps/probot-autolabeler
+# The matching patterns follow the .gitignore spec.
+# See: https://git-scm.com/docs/gitignore#_pattern_format
+
+infra:
Review comment:
What about we make the tags uppercased to make it look like the current tagging we do by @dongjoon-hyun's script?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364346
**[Test build #120829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120829/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609364346
**[Test build #120829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120829/testReport)** for PR 28114 at commit [`d6ecb1a`](https://github.com/apache/spark/commit/d6ecb1acb13f7e451c9dd934df60534cdae29269).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28114: [SPARK-31330]
Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-609556491
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120852/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28114:
[SPARK-31330] Automatically label PRs based on the paths they touch
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-611983332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25771/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org