You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/02 07:33:58 UTC
[GitHub] [airflow] Aditya-Kapadiya opened a new pull request, #26827: Update LICENCE
Aditya-Kapadiya opened a new pull request, #26827:
URL: https://github.com/apache/airflow/pull/26827
<!--
Changed "http" to "https" as http might lead to privacy and security issue and a user can also be redirected to other insecure site through MITM attack
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aditya-Kapadiya closed pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
Aditya-Kapadiya closed pull request #26827: Update LICENCE
URL: https://github.com/apache/airflow/pull/26827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264574547
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aditya-Kapadiya commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
Aditya-Kapadiya commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264590280
@XD-DENG Okay. If it automatically redirect to "https" than its fine. I will close this PR.
But Apache should update this minor changes in their license so, in future other contributors don't open the PR to change it to "https" in past this link used to open in "http" so, I thought of requesting a change.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264586756
The license itself is a legal content, and it's not a small deal to update it, even just a single character, IMO.
The "security concern" should not apply here, given Apache site already automatically redirects visitors to HTTPS, and the page is not for transmitting any sensitive info.
Here I would strongly prefer to be aligned with whatever content Apache Software Foundation is having in their official source (https://www.apache.org/licenses/LICENSE-2.0, or https://www.apache.org/licenses/LICENSE-2.0.txt). I also checked other projects, like Spark and Cassandra, and they didn't touch their license in any way either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264587130
Hi @turbaszek , CCing you as the author mentioned another similar PR that you helped review (https://github.com/apache/comdev-site/pull/70). Please find my thoughts above. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264590756
Hi @Aditya-Kapadiya , this is only because it's the LICENSE file, the legal foundation of the projects. A single-character change to it will need legal attention and effort.
If you notice any usage of HTTP over HTTPS anywhere else (**other than LICENSE**), please do help point out and raise a PR, and we would be more than happy to change accordingly. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264575239
So for the reason I shared above, I would suggest to close this if you also agree, @Aditya-Kapadiya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aditya-Kapadiya commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
Aditya-Kapadiya commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264591271
@XD-DENG Sure, I will do that if found any such usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aditya-Kapadiya commented on pull request #26827: Update LICENCE
Posted by GitBox <gi...@apache.org>.
Aditya-Kapadiya commented on PR #26827:
URL: https://github.com/apache/airflow/pull/26827#issuecomment-1264585589
Hello, @XD-DENG I also updated this changes in the below shown repository and they accepted the change. And this changes are made in the URL to make it secure. They doesn't create any conflicts. And still if you cannot accept this PR it would be great if you can guide me through the process of updating that license at (https://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org