You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2012/06/05 03:43:27 UTC
[jira] [Created] (FELIX-3536) Consider putting the non-spec
ComponentFactory behavior in a separate class
David Jencks created FELIX-3536:
-----------------------------------
Summary: Consider putting the non-spec ComponentFactory behavior in a separate class
Key: FELIX-3536
URL: https://issues.apache.org/jira/browse/FELIX-3536
Project: Felix
Issue Type: Bug
Components: Declarative Services (SCR)
Affects Versions: scr-1.8.0
Reporter: David Jencks
Assignee: David Jencks
Fix For: scr-1.8.0
I personally find it pretty confusing to figure out which parts of CompnentFactoryImpl relate to the spec behavior and which relate to the non-spec ManagedServiceFactory-like backwards compatible behavior enabled with the "ds.factory.enabled" configuration flag. I'd like to suggest putting the non-spec behavior in a separate class, see patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3536) Consider putting the non-spec
ComponentFactory behavior in a separate class
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated FELIX-3536:
--------------------------------
Attachment: FELIX-3536.diff
Suggestion on how to split spec and non-spec behavior to make it clearer what is required for spec behavior. Also includes determining which state is the satsified state by returning from the class rather than using a switch statement, which is a separate change.
> Consider putting the non-spec ComponentFactory behavior in a separate class
> ---------------------------------------------------------------------------
>
> Key: FELIX-3536
> URL: https://issues.apache.org/jira/browse/FELIX-3536
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-1.8.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: scr-1.8.0
>
> Attachments: FELIX-3536.diff
>
>
> I personally find it pretty confusing to figure out which parts of CompnentFactoryImpl relate to the spec behavior and which relate to the non-spec ManagedServiceFactory-like backwards compatible behavior enabled with the "ds.factory.enabled" configuration flag. I'd like to suggest putting the non-spec behavior in a separate class, see patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3536) Consider putting the non-spec
ComponentFactory behavior in a separate class
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks resolved FELIX-3536.
---------------------------------
Resolution: Fixed
I made m_componentInstances private again, good idea, and committed in rev 1346660.
> Consider putting the non-spec ComponentFactory behavior in a separate class
> ---------------------------------------------------------------------------
>
> Key: FELIX-3536
> URL: https://issues.apache.org/jira/browse/FELIX-3536
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-1.8.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: scr-1.8.0
>
> Attachments: FELIX-3536.diff
>
>
> I personally find it pretty confusing to figure out which parts of CompnentFactoryImpl relate to the spec behavior and which relate to the non-spec ManagedServiceFactory-like backwards compatible behavior enabled with the "ds.factory.enabled" configuration flag. I'd like to suggest putting the non-spec behavior in a separate class, see patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3536) Consider putting the non-spec
ComponentFactory behavior in a separate class
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289355#comment-13289355 ]
Felix Meschberger commented on FELIX-3536:
------------------------------------------
The one thing I don't like about the patch is that the m_componentInstances field is changed to be protected. I would really like to keep this private if possible.
> determining which state is the satsified state
I have been contemplating something along these lines, too. So I am ok with this change
So, +1 to apply this.
> Consider putting the non-spec ComponentFactory behavior in a separate class
> ---------------------------------------------------------------------------
>
> Key: FELIX-3536
> URL: https://issues.apache.org/jira/browse/FELIX-3536
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-1.8.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: scr-1.8.0
>
> Attachments: FELIX-3536.diff
>
>
> I personally find it pretty confusing to figure out which parts of CompnentFactoryImpl relate to the spec behavior and which relate to the non-spec ManagedServiceFactory-like backwards compatible behavior enabled with the "ds.factory.enabled" configuration flag. I'd like to suggest putting the non-spec behavior in a separate class, see patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (FELIX-3536) Consider putting the non-spec
ComponentFactory behavior in a separate class
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed FELIX-3536.
------------------------------------
Close after release
> Consider putting the non-spec ComponentFactory behavior in a separate class
> ---------------------------------------------------------------------------
>
> Key: FELIX-3536
> URL: https://issues.apache.org/jira/browse/FELIX-3536
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-1.8.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: scr-1.6.2
>
> Attachments: FELIX-3536.diff
>
>
> I personally find it pretty confusing to figure out which parts of CompnentFactoryImpl relate to the spec behavior and which relate to the non-spec ManagedServiceFactory-like backwards compatible behavior enabled with the "ds.factory.enabled" configuration flag. I'd like to suggest putting the non-spec behavior in a separate class, see patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3536) Consider putting the non-spec
ComponentFactory behavior in a separate class
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-3536:
-------------------------------------
Fix Version/s: (was: scr-1.8.0)
scr-1.6.2
> Consider putting the non-spec ComponentFactory behavior in a separate class
> ---------------------------------------------------------------------------
>
> Key: FELIX-3536
> URL: https://issues.apache.org/jira/browse/FELIX-3536
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR)
> Affects Versions: scr-1.8.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: scr-1.6.2
>
> Attachments: FELIX-3536.diff
>
>
> I personally find it pretty confusing to figure out which parts of CompnentFactoryImpl relate to the spec behavior and which relate to the non-spec ManagedServiceFactory-like backwards compatible behavior enabled with the "ds.factory.enabled" configuration flag. I'd like to suggest putting the non-spec behavior in a separate class, see patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira