[jira] [Updated] (ISIS-1172) Logo in wicket viewer should be calculated relative to context root

["Dan Haywood (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ISIS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood updated ISIS-1172:
------------------------------
         Assignee: Dan Haywood
    Fix Version/s:     (was: 1.16.0)
                   1.14.0

> Logo in wicket viewer should be calculated relative to context root
> -------------------------------------------------------------------
>
>                 Key: ISIS-1172
>                 URL: https://issues.apache.org/jira/browse/ISIS-1172
>             Project: Isis
>          Issue Type: Bug
>          Components: Core: Viewer: Wicket
>    Affects Versions: 1.9.0
>            Reporter: Jörg Rade
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.14.0
>
>
> {code}
> bind(String.class).annotatedWith(Names.named("brandLogoHeader"))
> .toInstance("/images/knife-logo-header.png");
> {code}
> doesn't work for me. I had to specify "/sdm-webapp/images/knife-logo-header.png".
> Tried. using "images/knife-logo-header.png" (-)
> Compared generated the simple app from the maven archetype and diffed my web.xml against the generated and adopted my web.xml to match my SimpleApplication package name. (-) 
> Analysis by Martin:
> Wicket automatically calculates the context relative path for plain HTML <img> elements in your markup.
> In the current case the <img> element is connected to a Java component, i.e. it has wicket:id attribute, and that's why Wicket doesn't apply any special logic on it.
> IMO we should improve Isis to always calculate context relative path for the logo url.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)