You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Chetan Mehrotra (JIRA)" <ji...@apache.org> on 2017/10/11 17:41:00 UTC

[jira] [Comment Edited] (OAK-6803) Provide a way to for persistent cache to determine which all nodes can be cached

    [ https://issues.apache.org/jira/browse/OAK-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200649#comment-16200649 ] 

Chetan Mehrotra edited comment on OAK-6803 at 10/11/17 5:40 PM:
----------------------------------------------------------------

[updated patch|^OAK-6803-v2.patch] with benchmark support

# Results without enabling this feature
{noformat}
$ java -jar oak-benchmarks-1.8-SNAPSHOT.jar benchmark SetPropertyTest Oak-Mongo
Apache Jackrabbit Oak 1.8-SNAPSHOT
# SetPropertyTest                  C     min     10%     50%     90%     max       N 
Oak-Mongo                          1    2044    2101    2454    3288    3318      24
{noformat}
# Results post enabling this
{noformat}
java -DpersistentCacheIncludes="/libs,/apps" -jar oak-benchmarks-1.8-SNAPSHOT.jar benchmark SetPropertyTest Oak-Mongo
Apache Jackrabbit Oak 1.8-SNAPSHOT
# SetPropertyTest                  C     min     10%     50%     90%     max       N 
Configuring persistent cache to only cache nodes under paths [/libs, /apps]
Oak-Mongo                          1    1771    1896    2115    2784    2922      28
{noformat}

[~mreutegg] Please review


was (Author: chetanm):
[updated patch|^OAK-6803-v2.patch] with benchmark support

#Results without enabling this feature
{noformat}
$ java -jar oak-benchmarks-1.8-SNAPSHOT.jar benchmark SetPropertyTest Oak-Mongo
Apache Jackrabbit Oak 1.8-SNAPSHOT
# SetPropertyTest                  C     min     10%     50%     90%     max       N 
Oak-Mongo                          1    2044    2101    2454    3288    3318      24
{noformat}
# Results post enabling this
{noformat}
java -DpersistentCacheIncludes="/libs,/apps" -jar oak-benchmarks-1.8-SNAPSHOT.jar benchmark SetPropertyTest Oak-Mongo
Apache Jackrabbit Oak 1.8-SNAPSHOT
# SetPropertyTest                  C     min     10%     50%     90%     max       N 
Configuring persistent cache to only cache nodes under paths [/libs, /apps]
Oak-Mongo                          1    1771    1896    2115    2784    2922      28
{noformat}

[~mreutegg] Please review

> Provide a way to for persistent cache to determine which all nodes can be cached
> --------------------------------------------------------------------------------
>
>                 Key: OAK-6803
>                 URL: https://issues.apache.org/jira/browse/OAK-6803
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.8
>
>         Attachments: OAK-6803-v1.patch, OAK-6803-v2.patch
>
>
> Currently persistent cache if enabled for nodes caches all nodes accessed on the system. It would be better if it can be configured to only cache those nodes which are not volatile so that caching can be effective
> Purpose of this issue is to
> * Provide an extension point in PersistentCache logic to check if a node is to be cached
> * Provide an impl which relies on some static OSGi config to determine that
> Later we can make this impl dynamic i.e. rely on access pattern to cache imp stuff



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)