You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/01/28 11:35:12 UTC

[jira] [Resolved] (WICKET-5006) Improve null display value in AbstractSingleSelectChoice

     [ https://issues.apache.org/jira/browse/WICKET-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-5006.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 6.6.0
         Assignee: Martin Grigorov
    
> Improve null display value in AbstractSingleSelectChoice
> --------------------------------------------------------
>
>                 Key: WICKET-5006
>                 URL: https://issues.apache.org/jira/browse/WICKET-5006
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.5.0
>            Reporter: Christoph Leiter
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 6.6.0
>
>         Attachments: WICKET-5006.patch
>
>
> AbstractSingleSelectChoice makes it hard to customize the display values for null because it's hard coded to look it up by property keys. This is done in getDefaultChoice and it's not possible to change the behavior without overriding the whole method.
> I extracted getNullValidDisplayValue and getNullKeyDisplayValue which are then called in getDefaultChoice and default to the current behavior. Now subclasses can change these values easily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira