You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2026/07/18 22:16:27 UTC
[Impala-ASF-CR] tested performance stuff
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24604
Change subject: tested performance stuff
......................................................................
tested performance stuff
Change-Id: I2a0a6cbd006fadfc39f0e7374711c65ca1d5de2a
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java
8 files changed, 199 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/24604/1
--
To view, visit http://gerrit.cloudera.org:8080/24604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a0a6cbd006fadfc39f0e7374711c65ca1d5de2a
Gerrit-Change-Number: 24604
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] tested performance stuff
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change. ( http://gerrit.cloudera.org:8080/24604 )
Change subject: tested performance stuff
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/24604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2a0a6cbd006fadfc39f0e7374711c65ca1d5de2a
Gerrit-Change-Number: 24604
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] tested performance stuff
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24604 )
Change subject: tested performance stuff
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23295/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a0a6cbd006fadfc39f0e7374711c65ca1d5de2a
Gerrit-Change-Number: 24604
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Jul 2026 22:41:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] tested performance stuff
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24604 )
Change subject: tested performance stuff
......................................................................
Patch Set 1:
(6 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java
File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java:
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@27
PS1, Line 27: import org.apache.calcite.rel.core.Aggregate;
unused import: org.apache.calcite.rel.core.Aggregate
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@29
PS1, Line 29: import org.apache.calcite.rel.core.Project;
unused import: org.apache.calcite.rel.core.Project
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@32
PS1, Line 32: import org.apache.calcite.rel.metadata.RelColumnOrigin;;
unused import: org.apache.calcite.rel.metadata.RelColumnOrigin;
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java
File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java:
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java@144
PS1, Line 144: || Math.abs(1.0 - (this.cpu + this.io) / (other.getCpu() + other.getIo())) < EPSILON;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java:
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@56
PS1, Line 56: import java.util.List;
unused import: java.util.List
http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@133
PS1, Line 133: runOptimizeNodesProgram(relBuilder, rexBuilder, optimizedJoinPlan, simplifier, true);
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a0a6cbd006fadfc39f0e7374711c65ca1d5de2a
Gerrit-Change-Number: 24604
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Jul 2026 22:21:39 +0000
Gerrit-HasComments: Yes