You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/16 03:16:09 UTC

[GitHub] [flink] zhoulii opened a new pull request, #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

zhoulii opened a new pull request, #19984:
URL: https://github.com/apache/flink/pull/19984

   ## What is the purpose of the change
   
   - test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable
   - Rework GlobFilePathFilterTest to be based on AssertJ
   
   ## Verifying this change
   
   - covered by existed ut
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhoulii commented on a diff in pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhoulii commented on code in PR #19984:
URL: https://github.com/apache/flink/pull/19984#discussion_r901196339


##########
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java:
##########
@@ -27,14 +27,13 @@
 import java.io.IOException;
 import java.util.Collections;
 
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class GlobFilePathFilterTest {
     @Test

Review Comment:
   Thanks for your suggestion, I will fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhoulii commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhoulii commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1157428942

   Hi @zhuzhurk ，can you help to review the changes when you're free ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhoulii commented on pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhoulii commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1160009844

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1160110155

   Thanks for the reviewing. @reswqa 
   Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhoulii commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhoulii commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1157363869

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa commented on a diff in pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
reswqa commented on code in PR #19984:
URL: https://github.com/apache/flink/pull/19984#discussion_r901138718


##########
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java:
##########
@@ -27,14 +27,13 @@
 import java.io.IOException;
 import java.util.Collections;
 
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class GlobFilePathFilterTest {
     @Test

Review Comment:
   ```suggestion
       @Test -> @org.junit.jupiter.api.Test;
   ```



##########
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java:
##########
@@ -27,14 +27,13 @@
 import java.io.IOException;
 import java.util.Collections;
 
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 public class GlobFilePathFilterTest {
     @Test

Review Comment:
   Using assertj is great, would you like to migrate this class to junit5 at the same time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhoulii commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhoulii commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1158562510

   > Would you open a JIRA ticket to fix this test issue? @zhoulii
   
   Hi @zhuzhurk , thanks for your reply. 
   
   I thought the change is minor, So I did not open a jira ticket. I am not that familiar with the convention of contribution, Do I need to open a jira ticket for this issue ? If so, please remind me and sorry for opening this pr before open a jira ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1158591560

   It's better to open a JIRA ticket for it so that fixes can be tracked. You can change the priority to minor though.
   There do exist some hotfix commits but they are usually parts of PRs of a JIRA ticket, so that they can still get tracked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1158553053

   Would you open a JIRA ticket to fix this test issue? @zhoulii 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19984:
URL: https://github.com/apache/flink/pull/19984#issuecomment-1157186972

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6726e9d27b74ebe57e9e986ebc4a8fe8a3afc628",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6726e9d27b74ebe57e9e986ebc4a8fe8a3afc628",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6726e9d27b74ebe57e9e986ebc4a8fe8a3afc628 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk merged pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

Posted by GitBox <gi...@apache.org>.
zhuzhurk merged PR #19984:
URL: https://github.com/apache/flink/pull/19984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org