You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/01 03:54:57 UTC

[GitHub] [hudi] codope commented on a change in pull request #4662: [HUDI-3293] Fixing default value for clustering small file config

codope commented on a change in pull request #4662:
URL: https://github.com/apache/hudi/pull/4662#discussion_r796247091



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
##########
@@ -83,7 +83,7 @@
 
   public static final ConfigProperty<String> PLAN_STRATEGY_SMALL_FILE_LIMIT = ConfigProperty
       .key(CLUSTERING_STRATEGY_PARAM_PREFIX + "small.file.limit")
-      .defaultValue(String.valueOf(600 * 1024 * 1024L))
+      .defaultValue(String.valueOf(100 * 1024 * 1024L))

Review comment:
       Currently, the default parquet small file limit for compaction is 100MB. With clustering, we want to be able to pack more. If 600MB is too big then we can reduce by half but let's keep it greater than parquet small file limit. Ideally, this should be some function of small file limit and estimate of data based on clustering sort columns.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org