You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Daniel Imberman (Jira)" <ji...@apache.org> on 2019/12/17 20:05:00 UTC
[jira] [Updated] (AIRFLOW-5532) Missed imagePullSecrets from pod
created from k8s executor
[ https://issues.apache.org/jira/browse/AIRFLOW-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Imberman updated AIRFLOW-5532:
-------------------------------------
Fix Version/s: 1.10.7
> Missed imagePullSecrets from pod created from k8s executor
> ----------------------------------------------------------
>
> Key: AIRFLOW-5532
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5532
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes
> Affects Versions: 2.0.0
> Environment: container image apache/airflow:master-python3.7-ci-slim which appears to be v2.0.0-dev
> Reporter: Ke Zhu
> Assignee: Ke Zhu
> Priority: Major
> Fix For: 1.10.7
>
>
> I used container image built based on *apache/airflow:master-python3.7-ci-slim* with k8s executor configured in airflow.cfg. all config options under section [kubernetes] and [kubernetes_secrets] are recognized successfully except option _image_pull_secrets_.
>
> Then I inspected the code at [https://github.com/apache/airflow/blob/47801057989046dfcf7b424ce54afee103803815/airflow/kubernetes/worker_configuration.py#L367-L387] where {{image_pull_secrets}} is NOT specified at all when constructing an object of {{PodGenerator}}. When reviewing further, I've noticed that the method {{WorkerConfiguration._get_image_pull_secrets()}} is not used at all. Which should be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)