[GitHub] [pulsar] mattisonchao commented on pull request #16803: Revert #16603 "[enh] Broker - Shared subscription: run filters in a separate (per-subscription) thread"

[GitBox <gi...@apache.org>]

mattisonchao commented on PR #16803:
URL: https://github.com/apache/pulsar/pull/16803#issuecomment-1196188809

   > @eolivelli Just have a private discussion with @mattisonchao, he also suggested only changing the default value.
   > 
   > However, IMO, keeping this option could still bring some potential risks. We have to note that if you're enabling this option, duplicated messages might be received. At the time, there is something wrong with this implementation. I think we should revert the implementation and only add it again after fixing the bug.
   
   @BewareMyPower 
   Yes, I change my mind. After a deep look at this PR,  I realise revert is better than changing it to false because this PR involved an issue and was originally just a performance issue.
   
   Hi, @eolivelli 
   Could you provide a fix at the release 2.11 period? If not, we can revert this PR before release 2.11.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org