You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Encaitar <gi...@git.apache.org> on 2016/04/18 15:36:39 UTC

[GitHub] incubator-quarks-website pull request: formatting and ordering

GitHub user Encaitar opened a pull request:

    https://github.com/apache/incubator-quarks-website/pull/44

    formatting and ordering

    I found it confusing to read about a sample application and the link takes me to the JavaDoc for a class I don't know where to find the code for. I found the code on github before I read about the code later in the readme. I've added a "code, docs" section so that you can go straight to the relevant pages fro the sample section (since it is supposed to be a quick start sample section). I've also sorted out the indentation of the sample java code, the main issue being the braces didn't line up.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Encaitar/incubator-quarks-website patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks-website/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #44
    
----
commit 113ca0dd82da89421dca2ec46080374c1d990362
Author: James Mullineux <ja...@uk.ibm.com>
Date:   2016-04-18T13:36:26Z

    formatting and ordering
    
    I found it confusing to read about a sample application and the link takes me to the JavaDoc for a class I don't know where to find the code for. I found the code on github before I read about the code later in the readme. I've added a "code, docs" section so that you can go straight to the relevant pages fro the sample section (since it is supposed to be a quick start sample section). I've also sorted out the indentation of the sample java code, the main issue being the braces didn't line up.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: formatting and ordering

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quarks-website/pull/44


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: formatting and ordering

Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on the pull request:

    https://github.com/apache/incubator-quarks-website/pull/44#issuecomment-215431083
  
    Thanks for your contribution! Sorry for the delay in getting this merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---