You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/07 18:11:22 UTC

[GitHub] [calcite] julianhyde commented on pull request #2628: [CALCITE-4917] Add test for 'IS NOT NULL(a) AND a=b' simplification

julianhyde commented on pull request #2628:
URL: https://github.com/apache/calcite/pull/2628#issuecomment-988157866


   @asolimando I acknowledge this is a particular challenge with the current workflow. (@vlsi please don't hit me over the head with it.)
   * We want really good commit messages
   * We want people to not squash/amend commits, to make them easier to review the deltas. Therefore the contributor can't change the commit message
   * Some committers forget to look at JIRA comments before merging (and squashing and rebasing) the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org