You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/18 13:17:32 UTC

[GitHub] [commons-rng] aherbert commented on a change in pull request #80: Minor Improvement:

aherbert commented on a change in pull request #80:
URL: https://github.com/apache/commons-rng/pull/80#discussion_r559559941



##########
File path: commons-rng-simple/src/main/java/org/apache/commons/rng/simple/ThreadLocalRandomSource.java
##########
@@ -69,7 +69,7 @@
      *
      * <p>This should only be modified to create new instances in a synchronized block.
      */
-    private static EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
+    private static final EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =

Review comment:
       This now fails checkstyle naming convensions. Please rename to SOURCES.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org