[GitHub] [incubator-sedona] Imbruced commented on pull request #487: [SEDONA-3] Sedona release 3.0 python adapter [WIP]

[GitBox <gi...@apache.org>]

Imbruced commented on pull request #487:
URL: https://github.com/apache/incubator-sedona/pull/487#issuecomment-723544195


   @jiayuasu I dicided to add python-adapter for simplicity reasons, only sedona-python-adapter is required to get all functionality. As you can see within travis script. 
   
   ```yml
   - find python-adapter/target/ -iregex "python-adapter\/target\/sedona-python-adapter-[0-9]\.[0-9]\.[0-9]-incubator\(-SNAPSHOT\)?\.jar" -exec cp {} $SPARK_HOME/jars \;
   - (cd python;pipenv run pytest tests)
   ```
   Assuming that user has Spark installed and properly set up Spark environment, he needs to add only one jar file. He can do that using SparkSession config argument or by putting the jar file within $SPARK_HOME/jars location.
   
   I removed confusing upload_jars function (and also dependency, **find_spark** which can cause issues with other libraries versions). sedona-python-adapter.jar file will be included as additional files on PyPI and I think it should not be uploaded on maven.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org