You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Tamm (JIRA)" <ji...@apache.org> on 2006/03/07 02:27:29 UTC
[jira] Updated: (LUCENE-507) CLONE -[PATCH] remove unused variables
[ http://issues.apache.org/jira/browse/LUCENE-507?page=all ]
Steven Tamm updated LUCENE-507:
-------------------------------
Attachment: Unused.patch
This fixes unnecessary casts, unused imports, unused private methods, and unused private variables. Most of the changes were in the JavaCC grammar files, which usually happens, so you can't really fix it. In java1.5, I'd normally just add @SuppressWarnings("unused"), but I ifgure that wouldn't solve it.
I only fixed demo, tools, and src. There's one problem import that said it was required for GCJ, which i think I fixed by changing the inner class references to be explicit.
Javadoc compiles with warnings only in contrib.
> CLONE -[PATCH] remove unused variables
> --------------------------------------
>
> Key: LUCENE-507
> URL: http://issues.apache.org/jira/browse/LUCENE-507
> Project: Lucene - Java
> Type: Improvement
> Components: Search
> Versions: unspecified
> Environment: Operating System: other
> Platform: Other
> Reporter: Steven Tamm
> Assignee: Lucene Developers
> Priority: Minor
> Attachments: Unused.patch
>
> Seems I'm the only person who has the "unused variable" warning turned on in
> Eclipse :-) This patch removes those unused variables and imports (for now
> only in the "search" package). This doesn't introduce changes in
> functionality, but it should be reviewed anyway: there might be cases where
> the variables *should* be used, but they are not because of a bug.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org