You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2014/06/10 16:50:09 UTC
Re: Review Request 19616: Added check for null return.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19616/#review45234
-----------------------------------------------------------
is this still a valid patch? should it be deleted?
- daan Hoogland
On April 15, 2014, 10:18 a.m., Alex Hitchins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19616/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 10:18 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added check for returned null, if received then throw exception.
>
> Amendments made as per dev mailing list comments.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e
>
> Diff: https://reviews.apache.org/r/19616/diff/
>
>
> Testing
> -------
>
> Compiled & ran.
>
>
> Thanks,
>
> Alex Hitchins
>
>
RE: Review Request 19616: Added check for null return.
Posted by Alex Hitchins <al...@alexhitchins.com>.
I will take a look later tonight.
Alex Hitchins | 07788 423 969 | 01892 523 587
-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
Sent: 10 June 2014 16:01
To: dev
Subject: Re: Review Request 19616: Added check for null return.
it wasn't addressed in the uploaded patch.
On Tue, Jun 10, 2014 at 4:59 PM, Alex Hitchins <al...@alexhitchins.com> wrote:
> I believe it to be valid still. I'll review later and confirm. I know you had comments on the patch which I had addressed.
>
>
>
>
>> On 10 Jun 2014, at 15:50, "daan Hoogland" <da...@gmail.com> wrote:
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/19616/#review45234
>> -----------------------------------------------------------
>>
>>
>> is this still a valid patch? should it be deleted?
>>
>> - daan Hoogland
>>
>>
>>> On April 15, 2014, 10:18 a.m., Alex Hitchins wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/19616/
>>> -----------------------------------------------------------
>>>
>>> (Updated April 15, 2014, 10:18 a.m.)
>>>
>>>
>>> Review request for cloudstack and daan Hoogland.
>>>
>>>
>>> Repository: cloudstack-git
>>>
>>>
>>> Description
>>> -------
>>>
>>> Added check for returned null, if received then throw exception.
>>>
>>> Amendments made as per dev mailing list comments.
>>>
>>>
>>> Diffs
>>> -----
>>>
>>> server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e
>>>
>>> Diff: https://reviews.apache.org/r/19616/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Compiled & ran.
>>>
>>>
>>> Thanks,
>>>
>>> Alex Hitchins
>>
--
Daan
Re: Review Request 19616: Added check for null return.
Posted by Daan Hoogland <da...@gmail.com>.
it wasn't addressed in the uploaded patch.
On Tue, Jun 10, 2014 at 4:59 PM, Alex Hitchins <al...@alexhitchins.com> wrote:
> I believe it to be valid still. I'll review later and confirm. I know you had comments on the patch which I had addressed.
>
>
>
>
>> On 10 Jun 2014, at 15:50, "daan Hoogland" <da...@gmail.com> wrote:
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/19616/#review45234
>> -----------------------------------------------------------
>>
>>
>> is this still a valid patch? should it be deleted?
>>
>> - daan Hoogland
>>
>>
>>> On April 15, 2014, 10:18 a.m., Alex Hitchins wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/19616/
>>> -----------------------------------------------------------
>>>
>>> (Updated April 15, 2014, 10:18 a.m.)
>>>
>>>
>>> Review request for cloudstack and daan Hoogland.
>>>
>>>
>>> Repository: cloudstack-git
>>>
>>>
>>> Description
>>> -------
>>>
>>> Added check for returned null, if received then throw exception.
>>>
>>> Amendments made as per dev mailing list comments.
>>>
>>>
>>> Diffs
>>> -----
>>>
>>> server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e
>>>
>>> Diff: https://reviews.apache.org/r/19616/diff/
>>>
>>>
>>> Testing
>>> -------
>>>
>>> Compiled & ran.
>>>
>>>
>>> Thanks,
>>>
>>> Alex Hitchins
>>
--
Daan
Re: Review Request 19616: Added check for null return.
Posted by Alex Hitchins <al...@alexhitchins.com>.
I believe it to be valid still. I'll review later and confirm. I know you had comments on the patch which I had addressed.
> On 10 Jun 2014, at 15:50, "daan Hoogland" <da...@gmail.com> wrote:
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19616/#review45234
> -----------------------------------------------------------
>
>
> is this still a valid patch? should it be deleted?
>
> - daan Hoogland
>
>
>> On April 15, 2014, 10:18 a.m., Alex Hitchins wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/19616/
>> -----------------------------------------------------------
>>
>> (Updated April 15, 2014, 10:18 a.m.)
>>
>>
>> Review request for cloudstack and daan Hoogland.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Added check for returned null, if received then throw exception.
>>
>> Amendments made as per dev mailing list comments.
>>
>>
>> Diffs
>> -----
>>
>> server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e
>>
>> Diff: https://reviews.apache.org/r/19616/diff/
>>
>>
>> Testing
>> -------
>>
>> Compiled & ran.
>>
>>
>> Thanks,
>>
>> Alex Hitchins
>