You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2017/04/27 12:33:16 UTC

[30/35] isis git commit: ISIS-1603: moves the markup from ScalarPanelTextAbstract.html down to its subclass, SclarPanelTextFieldAbstract.html

ISIS-1603: moves the markup from ScalarPanelTextAbstract.html down to its subclass, SclarPanelTextFieldAbstract.html


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/49013d08
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/49013d08
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/49013d08

Branch: refs/heads/ISIS-1603
Commit: 49013d08f090a5557197b1aa156b0aed50607da4
Parents: 8484d53
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Tue Apr 25 23:39:10 2017 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Thu Apr 27 13:26:40 2017 +0100

----------------------------------------------------------------------
 .../components/scalars/ScalarPanelAbstract.java |   2 +-
 .../scalars/ScalarPanelTextAbstract.html        |  87 ---------------
 .../scalars/ScalarPanelTextAbstract.java        |  11 +-
 .../scalars/ScalarPanelTextFieldAbstract.html   | 110 ++++++++++++++-----
 .../scalars/ScalarPanelTextFieldAbstract.java   |  14 ++-
 5 files changed, 99 insertions(+), 125 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/49013d08/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
----------------------------------------------------------------------
diff --git a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
index a03b917..71d9bd8 100644
--- a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
+++ b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
@@ -300,7 +300,7 @@ public abstract class ScalarPanelAbstract extends PanelAbstract<ScalarModel> imp
                         getComponentForRegular().setVisible(false);
                         scalarIfRegularInlinePromptForm.setVisible(true);
 
-                        target.add(ScalarPanelAbstract.this);
+                        target.add(scalarTypeContainer);
                     }
 
                     @Override

http://git-wip-us.apache.org/repos/asf/isis/blob/49013d08/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.html
----------------------------------------------------------------------
diff --git a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.html b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.html
index 9fd6bda..e69de29 100644
--- a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.html
+++ b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.html
@@ -1,87 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-
-         http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
--->
-<!DOCTYPE html>
-<html xmlns="http://www.w3.org/1999/xhtml"
-      xmlns:wicket="http://wicket.apache.org"
-      xml:lang="en"
-      lang="en">
-    <body>
-        <wicket:panel>
-            <div class="scalarNameAndValueComponentType"
-                 wicket:id="scalarTypeContainer">
-
-                <div class="form-group"
-                     wicket:id="scalarIfRegular">
-
-                    <label class="scalarName control-label"
-                           wicket:id="scalarName"
-                    >[Label text]</label>
-
-                    <span class="scalarValueWrapper">
-                        <div class="scalarPlaceholder">
-
-                            <span class="scalarValueInput">
-                                <span class="editing">
-
-                                    <a href="#"
-                                       name="scalarValueEditInline"
-                                       class="form-control input-sm scalarValueEditInline"
-                                       wicket:id="scalarValueEditInline">
-                                        <span wicket:id="scalarValueEditInlineLabel"></span>
-                                    </a>
-
-                                    <wicket:child/>
-
-                                    <a href="#"
-                                       class="edit fa fa-pencil-square-o"
-                                       wicket:id="editProperty"></a>
-                                </span>
-                            </span>
-
-                            <span class="associatedActionLinksRight"
-                                  wicket:id="associatedActionLinksRight"
-                            >[drop down]</span>
-                        </div>
-                        <span wicket:id="feedback" class="help-block"></span>
-                        <span wicket:id="associatedActionLinksBelow"></span>
-                    </span>
-                    <div class="clearfix"></div>
-                </div>
-
-                <div class="inlineEditForm"
-                     wicket:id="scalarIfRegularInlineEditForm" >
-                    <div><span>property edit form</span></div>
-                </div>
-
-                <wicket:container wicket:id="scalarIfCompact"></wicket:container>
-            </div>
-
-            <wicket:fragment wicket:id="compactAsInputCheckbox">
-                <input wicket:id="scalarIfCompact"
-                       type="checkbox"
-                       class="form-control" />
-            </wicket:fragment>
-
-            <wicket:fragment wicket:id="compactAsSpan">
-                <span wicket:id="scalarIfCompact"></span>
-            </wicket:fragment>
-        </wicket:panel>
-    </body>
-</html>

http://git-wip-us.apache.org/repos/asf/isis/blob/49013d08/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.java
----------------------------------------------------------------------
diff --git a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.java b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.java
index 198eb9e..7bfaf33 100644
--- a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.java
+++ b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextAbstract.java
@@ -20,16 +20,7 @@
 package org.apache.isis.viewer.wicket.ui.components.scalars;
 
 import org.apache.isis.viewer.wicket.model.models.ScalarModel;
-import org.apache.isis.viewer.wicket.ui.panels.PanelAbstract;
-
-/**
- * Adapter for {@link PanelAbstract panel}s that use a {@link ScalarModel} as
- * their backing model.
- * 
- * <p>
- * Supports the concept of being {@link Rendering#COMPACT} (eg within a table) or
- * {@link Rendering#REGULAR regular} (eg within a form).
- */
+
 public abstract class ScalarPanelTextAbstract extends ScalarPanelAbstract  {
 
     private static final long serialVersionUID = 1L;

http://git-wip-us.apache.org/repos/asf/isis/blob/49013d08/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
----------------------------------------------------------------------
diff --git a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
index 673e6e1..31538a6 100644
--- a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
+++ b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
@@ -22,36 +22,96 @@
       xmlns:wicket="http://wicket.apache.org"
       xml:lang="en"
       lang="en">
-    <body>
-        <wicket:extend>
-            <wicket:container wicket:id="scalarValueContainer"/>
+<body>
+<wicket:panel>
+    <div class="scalarNameAndValueComponentType"
+         wicket:id="scalarTypeContainer">
 
-            <wicket:fragment wicket:id="text">
-                <input
-                        type="text"
-                        name="scalarValue"
-                        class="form-control input-sm scalarValue"
-                        wicket:id="scalarValue" />
-            </wicket:fragment>
+        <div class="form-group"
+             wicket:id="scalarIfRegular">
+
+            <label class="scalarName control-label"
+                   wicket:id="scalarName"
+            >[Label text]</label>
+
+            <span class="scalarValueWrapper">
+                    <div class="scalarPlaceholder">
+
+                        <span class="scalarValueInput">
+                            <span class="editing">
+
+                                <a href="#"
+                                   name="scalarValueEditInline"
+                                   class="form-control input-sm scalarValueEditInline"
+                                   wicket:id="scalarValueEditInline">
+                                    <span wicket:id="scalarValueEditInlineLabel"></span>
+                                </a>
+
+                                <wicket:container wicket:id="scalarValueContainer"/>
+
+
+
+                                <a href="#"
+                                   class="edit fa fa-pencil-square-o"
+                                   wicket:id="editProperty"></a>
+                            </span>
+                        </span>
 
-            <wicket:fragment wicket:id="textarea">
+                        <span class="associatedActionLinksRight"
+                              wicket:id="associatedActionLinksRight"
+                        >[drop down]</span>
+                    </div>
+                    <span wicket:id="feedback" class="help-block"></span>
+                    <span wicket:id="associatedActionLinksBelow"></span>
+                </span>
+            <div class="clearfix"></div>
+        </div>
+
+        <div class="inlineEditForm"
+             wicket:id="scalarIfRegularInlineEditForm" >
+            <div><span>property edit form</span></div>
+        </div>
+
+        <wicket:container wicket:id="scalarIfCompact"></wicket:container>
+    </div>
+
+    <wicket:fragment wicket:id="text">
+        <input
+                type="text"
+                name="scalarValue"
+                class="form-control input-sm scalarValue"
+                wicket:id="scalarValue" />
+    </wicket:fragment>
+
+    <wicket:fragment wicket:id="textarea">
                 <textarea
                         name="scalarValue"
                         class="form-control scalarValue"
                         wicket:id="scalarValue">
                 </textarea>
-            </wicket:fragment>
-
-            <wicket:fragment wicket:id="date">
-                <div class="date">
-                    <input
-                            type="text"
-                            name="scalarValue"
-                            class="form-control input-sm scalarValue"
-                            wicket:id="scalarValue"/>
-                </div>
-            </wicket:fragment>
-
-        </wicket:extend>
-    </body>
+    </wicket:fragment>
+
+    <wicket:fragment wicket:id="date">
+        <div class="date">
+            <input
+                    type="text"
+                    name="scalarValue"
+                    class="form-control input-sm scalarValue"
+                    wicket:id="scalarValue"/>
+        </div>
+    </wicket:fragment>
+
+    <wicket:fragment wicket:id="compactAsInputCheckbox">
+        <input wicket:id="scalarIfCompact"
+               type="checkbox"
+               class="form-control" />
+    </wicket:fragment>
+
+    <wicket:fragment wicket:id="compactAsSpan">
+        <span wicket:id="scalarIfCompact"></span>
+    </wicket:fragment>
+
+</wicket:panel>
+</body>
 </html>
+

http://git-wip-us.apache.org/repos/asf/isis/blob/49013d08/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
----------------------------------------------------------------------
diff --git a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
index 332e2e8..8e28819 100644
--- a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
+++ b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.java
@@ -51,11 +51,21 @@ import org.apache.isis.viewer.wicket.model.links.LinkAndLabel;
 import org.apache.isis.viewer.wicket.model.models.ScalarModel;
 import org.apache.isis.viewer.wicket.ui.components.actionmenu.entityactions.EntityActionUtil;
 import org.apache.isis.viewer.wicket.ui.components.widgets.bootstrap.FormGroup;
+import org.apache.isis.viewer.wicket.ui.panels.PanelAbstract;
 import org.apache.isis.viewer.wicket.ui.util.CssClassAppender;
 
 /**
- * Adapter for {@link ScalarPanelAbstract scalar panel}s that are implemented
- * using a simple {@link TextField}.
+ * Adapter for {@link PanelAbstract panel}s that use a {@link ScalarModel} as
+ * their backing model.
+ *
+ * <p>
+ * Supports the concept of being {@link Rendering#COMPACT} (eg within a table) or
+ * {@link Rendering#REGULAR regular} (eg within a form).
+ * </p>
+ *
+ * <p>
+ * This implementation is for panels that use a textfield/text area.
+ * </p>
  */
 public abstract class ScalarPanelTextFieldAbstract<T extends Serializable> extends ScalarPanelTextAbstract {