You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/02/04 17:50:00 UTC

[GitHub] [helix] junkaixue commented on a change in pull request #1951: Fixes #1802 - messages intended for instances that are no longer in t…

junkaixue commented on a change in pull request #1951:
URL: https://github.com/apache/helix/pull/1951#discussion_r799685175



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -194,7 +194,8 @@ private void generateMessage(final Resource resource, final BaseControllerDataPr
         }
 
         if (pendingMessage != null && shouldCleanUpPendingMessage(pendingMessage, currentState,
-            currentStateOutput.getEndTime(resourceName, partition, instanceName))) {
+            currentStateOutput.getEndTime(resourceName, partition, instanceName)) && sessionIdMap
+            .containsKey(instanceName)) {

Review comment:
        I would suggest to move this check in side function of shouldCleanUpPendingMessage. This could make the all the check logic inside shouldCleanUpPendingMessage(.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org