You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2017/03/21 02:47:15 UTC
[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...
GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/39
GUACAMOLE-101: Documentation for LDAP User Filtering
Added documentation for the two properties added for supporting filtering of users and connections in LDAP.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-manual GUACAMOLE-101
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 6792fe240643ac9553bb96f45f1c1b41498ade44
Author: Nick Couchman <ni...@yahoo.com>
Date: 2017-03-21T02:45:48Z
GUACAMOLE-101: Add documentation for new user and connection filter properties.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/39#discussion_r108481671
--- Diff: src/chapters/ldap-auth.xml ---
@@ -395,6 +395,15 @@ dn: cn={4}guacConfigGroup,cn=schema,cn=config
aliases.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>ldap-user-search-filter</property></term>
--- End diff --
OK - I built the manual from these changes and noticed that the organization of this section is slightly off. There's a section in the middle of this area which is devoted to users and search:
> 
but the new `ldap-user-search-filter` property documentation is simply appended to the end of the section among other unrelated properties:
> 
Perhaps this should be moved up a bit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/39#discussion_r108459743
--- Diff: src/chapters/ldap-auth.xml ---
@@ -384,6 +384,15 @@ dn: cn={4}guacConfigGroup,cn=schema,cn=config
have no effect on Guacamole configurations.</emphasis></para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>ldap-user-search-filter</property></term>
+ <listitem>
+ <para>The search filter used to query the LDAP tree for users that
+ can log into and be granted privileges in Guacamole. <emphasis>If
+ this property is omitted the default of (objectClass=*) will be used.
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/39#discussion_r108458970
--- Diff: src/chapters/ldap-auth.xml ---
@@ -384,6 +384,15 @@ dn: cn={4}guacConfigGroup,cn=schema,cn=config
have no effect on Guacamole configurations.</emphasis></para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>ldap-user-search-filter</property></term>
+ <listitem>
+ <para>The search filter used to query the LDAP tree for users that
+ can log into and be granted privileges in Guacamole. <emphasis>If
+ this property is omitted the default of (objectClass=*) will be used.
--- End diff --
Please place `(objectClass=*)` within quotes, so it's clear that it's a literal value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/39#discussion_r108482474
--- Diff: src/chapters/ldap-auth.xml ---
@@ -395,6 +395,15 @@ dn: cn={4}guacConfigGroup,cn=schema,cn=config
aliases.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>ldap-user-search-filter</property></term>
--- End diff --
Yeah, that makes sense. I moved it just below the ldap-username-attribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---