You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/06/05 11:25:43 UTC
incubator-kylin git commit: minor, format code on DictionaryManager
Repository: incubator-kylin
Updated Branches:
refs/heads/0.8.0 d1a2682a5 -> 9f7567a43
minor, format code on DictionaryManager
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/9f7567a4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/9f7567a4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/9f7567a4
Branch: refs/heads/0.8.0
Commit: 9f7567a43899681eab5fb9dcd58cdf706c7fbb7a
Parents: d1a2682
Author: Li, Yang <ya...@ebay.com>
Authored: Fri Jun 5 17:25:04 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Fri Jun 5 17:25:04 2015 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/dict/DictionaryManager.java | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/9f7567a4/dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
----------------------------------------------------------------------
diff --git a/dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java b/dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
index be45899..2d53ab2 100644
--- a/dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
+++ b/dictionary/src/main/java/org/apache/kylin/dict/DictionaryManager.java
@@ -204,8 +204,7 @@ public class DictionaryManager {
// 1. If 'useDict' specifies pre-defined data set, use that
// 2. Otherwise find a lookup table to scan through
- // Note FK on fact table is supported by scan the related PK on lookup
- // table
+ // Note FK on fact table is supported by scan the related PK on lookup table
//String useDict = cube.getRowkey().getDictionary(col);
@@ -279,10 +278,7 @@ public class DictionaryManager {
TableSignature input = dictInfo.getInput();
for (String existing : existings) {
- DictionaryInfo existingInfo = load(existing, false); // skip cache,
- // direct
- // load from
- // store
+ DictionaryInfo existingInfo = load(existing, false); // skip cache, direct load from store
if (input.equals(existingInfo.getInput()))
return existing;
}
@@ -298,9 +294,7 @@ public class DictionaryManager {
for (String existing : existings) {
logger.info("Checking dup dict :" + existing);
- DictionaryInfo existingInfo = load(existing, true); // skip cache,
- // direct load
- // from store
+ DictionaryInfo existingInfo = load(existing, true); // skip cache, direct load from store
if (existingInfo == null)
logger.info("existingInfo is null");