You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2025/04/21 13:42:46 UTC

[I] Migrate `logical_plan` tests to `insta` [datafusion]

blaginin opened a new issue, #15792:
URL: https://github.com/apache/datafusion/issues/15792

   In https://github.com/apache/datafusion/issues/15178, we're switching hard-coded constants in tests to `insta`. 
   
   This issue targets updating **logical_plan tests** (`datafusion/expr/src/logical_plan`). 
   
   Examples of tests that need to be switched to `insta`
   
   - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/expr/src/logical_plan/plan.rs#L4091-L4104
   - https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/expr/src/logical_plan/builder.rs#L2348-L2356
   - Debatable, but I think we should also update doc tests, e.g.  https://github.com/apache/datafusion/blob/91ad9fda2652f584d786a964ee205829e7a84580/datafusion/expr/src/logical_plan/plan.rs#L1262-L1265 - although that said, we should keep doc tests as simple as possible and easy to reproduce for the users. Feel free to write your thoughts on that before submitting the PR so we can discuss it.
   ... and so on - check `assert_eq!` `format!("{plan}")`, `TableScan:` 
   
   Check [the original issue](https://github.com/apache/datafusion/issues/15178) for tips on how to do the switch and examples of completed PRs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Migrate `logical_plan` tests to `insta` [datafusion]

Posted by "Shreyaskr1409 (via GitHub)" <gi...@apache.org>.
Shreyaskr1409 commented on issue #15792:
URL: https://github.com/apache/datafusion/issues/15792#issuecomment-2832145682

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Migrate `logical_plan` tests to `insta` [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #15792: Migrate `logical_plan` tests to `insta`
URL: https://github.com/apache/datafusion/issues/15792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org