[GitHub] [airflow] kaxil commented on a change in pull request #11344: Fix scheduler bug when a dag has invalid schedule_interval

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #11344:
URL: https://github.com/apache/airflow/pull/11344#discussion_r501609193



##########
File path: airflow/models/dagbag.py
##########
@@ -352,9 +352,9 @@ def _process_modules(self, filepath, mods, file_last_changed_on_disk):
                     dag.fileloc = filepath
             try:
                 dag.is_subdag = False
-                self.bag_dag(dag=dag, root_dag=dag)
                 if isinstance(dag.normalized_schedule_interval, str):
                     croniter(dag.normalized_schedule_interval)
+                self.bag_dag(dag=dag, root_dag=dag)

Review comment:
       Can we add a simple test case for this, i.e. to show what happens when a garbage value is provided to schedule-interval




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org