[jira] [Commented] (LUCENE-5670) org.apache.lucene.util.fst.FST should skip over outputs it is not interested in

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997627#comment-13997627 ] 

Michael McCandless commented on LUCENE-5670:
--------------------------------------------

This looks like a good idea; why did you need to add DataInput.skipBytes?  Don't we already have that method (taking long)?

> org.apache.lucene.util.fst.FST should skip over outputs it is not interested in
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-5670
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5670
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 4.7
>            Reporter: Christian Ziech
>            Priority: Minor
>         Attachments: LUCENE-5670.patch
>
>
> Currently the FST uses the read(DataInput) method from the Outputs class to skip over outputs it actually is not interested in. For most use cases this just creates some additional objects that are immediately destroyed again.
> When traversing an FST with non-trivial data however this can easily add up to several excess objects that nobody actually ever read.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org