You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2020/04/21 17:43:37 UTC
Review Request 72407: Enabled io::poll read test on Windows / added
io::poll write test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72407/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Greg Mann.
Repository: mesos
Description
-------
Now that io::poll is implemented for windows we need to test it.
This also adds a test of write polling, which was absent before.
Diffs
-----
3rdparty/libprocess/src/tests/io_tests.cpp 7e1d5148e2e3a80dcaaa5deb9d7a3ab080735994
Diff: https://reviews.apache.org/r/72407/diff/1/
Testing
-------
make check and started running it through internal CI
Thanks,
Benjamin Mahler
Re: Review Request 72407: Enabled io::poll read test on Windows /
added io::poll write test.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72407/#review220449
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 21, 2020, 5:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72407/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 5:43 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now that io::poll is implemented for windows we need to test it.
>
> This also adds a test of write polling, which was absent before.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/io_tests.cpp 7e1d5148e2e3a80dcaaa5deb9d7a3ab080735994
>
>
> Diff: https://reviews.apache.org/r/72407/diff/1/
>
>
> Testing
> -------
>
> make check and started running it through internal CI
>
>
> Thanks,
>
> Benjamin Mahler
>
>