[GitHub] [samza] prateekm commented on a change in pull request #1046: SAMZA-2211: [Cleanup] Move RunLoop to container package

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1046: SAMZA-2211: [Cleanup] Move RunLoop to container package
URL: https://github.com/apache/samza/pull/1046#discussion_r286583928
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
 ##########
 @@ -50,7 +55,13 @@
 
 
 /**
- * The RunLoop supports multithreading execution of Samza {@link AsyncStreamTask}s.
+ * The run loop supports both single-threaded and multi-threaded execution models.
+ *    <p>
+ *      If job.container.thread.pool.size &gt; 1 (multi-threaded), operations like commit, window and timer for all tasks within a container
+ *      happens on a thread pool.
+ *      If job.container.thread.pool.size &lt; 1 (single-threaded), operations for all tasks are multiplexed onto one execution thread.
+ *    </p>.
+ *    Note: In both models, process for all tasks happen sequentially on the main execution thread.
 
 Review comment:
   "process/processAsync for all tasks is called on the run loop thread"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services