[GitHub] [iceberg] kbendick commented on a change in pull request #4157: Flink: Support configurable Scala version.

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #4157:
URL: https://github.com/apache/iceberg/pull/4157#discussion_r809665070



##########
File path: settings.gradle
##########
@@ -87,30 +87,30 @@ if (!flinkVersions.isEmpty()) {
 }
 
 if (flinkVersions.contains("1.12")) {
-  include ':iceberg-flink:flink-1.12'
-  include ':iceberg-flink:flink-runtime-1.12'
-  project(':iceberg-flink:flink-1.12').projectDir = file('flink/v1.12/flink')
-  project(':iceberg-flink:flink-1.12').name = 'iceberg-flink-1.12'
-  project(':iceberg-flink:flink-runtime-1.12').projectDir = file('flink/v1.12/flink-runtime')
-  project(':iceberg-flink:flink-runtime-1.12').name = 'iceberg-flink-runtime-1.12'
+  include ":iceberg-flink:flink-1.12_${scalaVersion}"
+  include ":iceberg-flink:flink-runtime-1.12_${scalaVersion}"
+  project(":iceberg-flink:flink-1.12_${scalaVersion}").projectDir = file('flink/v1.12/flink')
+  project(":iceberg-flink:flink-1.12_${scalaVersion}").name = "iceberg-flink-1.12_${scalaVersion}"
+  project(":iceberg-flink:flink-runtime-1.12_${scalaVersion}").projectDir = file('flink/v1.12/flink-runtime')
+  project(":iceberg-flink:flink-runtime-1.12_${scalaVersion}").name = "iceberg-flink-runtime-1.12_${scalaVersion}"
 }
 
 if (flinkVersions.contains("1.13")) {
-  include ':iceberg-flink:flink-1.13'
-  include ':iceberg-flink:flink-runtime-1.13'
-  project(':iceberg-flink:flink-1.13').projectDir = file('flink/v1.13/flink')
-  project(':iceberg-flink:flink-1.13').name = 'iceberg-flink-1.13'
-  project(':iceberg-flink:flink-runtime-1.13').projectDir = file('flink/v1.13/flink-runtime')
-  project(':iceberg-flink:flink-runtime-1.13').name = 'iceberg-flink-runtime-1.13'
+  include ":iceberg-flink:flink-1.13_${scalaVersion}"
+  include ":iceberg-flink:flink-runtime-1.13_${scalaVersion}"
+  project(":iceberg-flink:flink-1.13_${scalaVersion}").projectDir = file('flink/v1.13/flink')
+  project(":iceberg-flink:flink-1.13_${scalaVersion}").name = "iceberg-flink-1.13_${scalaVersion}"
+  project(":iceberg-flink:flink-runtime-1.13_${scalaVersion}").projectDir = file('flink/v1.13/flink-runtime')
+  project(":iceberg-flink:flink-runtime-1.13_${scalaVersion}").name = "iceberg-flink-runtime-1.13_${scalaVersion}"
 }
 
 if (flinkVersions.contains("1.14")) {
-  include ':iceberg-flink:flink-1.14'
-  include ':iceberg-flink:flink-runtime-1.14'
-  project(':iceberg-flink:flink-1.14').projectDir = file('flink/v1.14/flink')
-  project(':iceberg-flink:flink-1.14').name = 'iceberg-flink-1.14'
-  project(':iceberg-flink:flink-runtime-1.14').projectDir = file('flink/v1.14/flink-runtime')
-  project(':iceberg-flink:flink-runtime-1.14').name = 'iceberg-flink-runtime-1.14'
+  include ":iceberg-flink:flink-1.14_${scalaVersion}"
+  include ":iceberg-flink:flink-runtime-1.14_${scalaVersion}"
+  project(":iceberg-flink:flink-1.14_${scalaVersion}").projectDir = file('flink/v1.14/flink')
+  project(":iceberg-flink:flink-1.14_${scalaVersion}").name = "iceberg-flink-1.14_${scalaVersion}"
+  project(":iceberg-flink:flink-runtime-1.14_${scalaVersion}").projectDir = file('flink/v1.14/flink-runtime')
+  project(":iceberg-flink:flink-runtime-1.14_${scalaVersion}").name = "iceberg-flink-runtime-1.14_${scalaVersion}"

Review comment:
       Correct me if I’m wrong, but I think we need to be able to publish / build all combinations of Flink / Scala versions here. For example, when publishing a new release to maven we need to build all of the artifacts.
   
   Is it possible to do that in a way that doesn’t require two build calls (one for each Scala version)? I’m not a highly experienced Scala with gradle user, so I might be mistaken or it might be necessary to use two build calls.
   
   But it makes the release process more cumbersome and particular to have to call build multiple times, which is something we’ve been trying to make more streamlined (the build / release process).
   
   I’m ok with iterating on things and would not block on this, but it is a concern for me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org