You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yoshikazu Nojima <ma...@ynojima.net> on 2013/10/29 06:00:01 UTC
Review Request 15012: CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be aligned
with Linux kernel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15012/
-----------------------------------------------------------
Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
Repository: cloudstack-git
Description
-------
Linux vxlan interface doesn't accept VNI:16777215.
https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140
As far as I read internet draft ( http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05 ),
16777215 is a valid VNI, but it cannot be used in Linux now.
This patch decrements MAX_VXLAN_VNI to 16777214.
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java 61c070a
Diff: https://reviews.apache.org/r/15012/diff/
Testing
-------
I confirmed VNI validation works by specifying 16777215-16777215 to id range via add zone wizard.
Thanks,
Yoshikazu Nojima
Re: Review Request 15012: CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be
aligned with Linux kernel
Posted by Toshiaki Hatano <ha...@haeena.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15012/#review27660
-----------------------------------------------------------
Ship it!
Ship It!
- Toshiaki Hatano
On Oct. 29, 2013, 5 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15012/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 5 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Linux vxlan interface doesn't accept VNI:16777215.
> https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140
>
> As far as I read internet draft ( http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05 ),
> 16777215 is a valid VNI, but it cannot be used in Linux now.
>
> This patch decrements MAX_VXLAN_VNI to 16777214.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 61c070a
>
> Diff: https://reviews.apache.org/r/15012/diff/
>
>
> Testing
> -------
>
> I confirmed VNI validation works by specifying 16777215-16777215 to id range via add zone wizard.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15012: CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be
aligned with Linux kernel
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15012/#review27778
-----------------------------------------------------------
Commit 089026f6afb4de1a1f81b71d291a79d6e327a3e1 in branch refs/heads/master from ynojima
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=089026f ]
CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be aligned with Linux kernel
Linux vxlan interface doesn't accept VNI:16777215 now.
Signed-off-by: Toshiaki Hatano <ha...@haeena.net>
- ASF Subversion and Git Services
On Oct. 29, 2013, 5 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15012/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 5 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Linux vxlan interface doesn't accept VNI:16777215.
> https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140
>
> As far as I read internet draft ( http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05 ),
> 16777215 is a valid VNI, but it cannot be used in Linux now.
>
> This patch decrements MAX_VXLAN_VNI to 16777214.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 61c070a
>
> Diff: https://reviews.apache.org/r/15012/diff/
>
>
> Testing
> -------
>
> I confirmed VNI validation works by specifying 16777215-16777215 to id range via add zone wizard.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15012: CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be
aligned with Linux kernel
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15012/#review27695
-----------------------------------------------------------
Ship it!
Toshiaki, please commit.
- Marcus Sorensen
On Oct. 29, 2013, 5 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15012/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 5 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Linux vxlan interface doesn't accept VNI:16777215.
> https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140
>
> As far as I read internet draft ( http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05 ),
> 16777215 is a valid VNI, but it cannot be used in Linux now.
>
> This patch decrements MAX_VXLAN_VNI to 16777214.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 61c070a
>
> Diff: https://reviews.apache.org/r/15012/diff/
>
>
> Testing
> -------
>
> I confirmed VNI validation works by specifying 16777215-16777215 to id range via add zone wizard.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>