You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/05/13 21:24:11 UTC
[GitHub] [solr] cpoerschke opened a new pull request #126: SOLR-14920: add spotless and gjf (automatic code formatter) plumbing
cpoerschke opened a new pull request #126:
URL: https://github.com/apache/solr/pull/126
The here idea is to start on https://issues.apache.org/jira/browse/SOLR-14920 by adding plumbing modelled on https://issues.apache.org/jira/browse/LUCENE-9564 but to not use it as yet. Subsequent pull requests (@cpoerschke to add example here shortly) as-and-when could then incrementally remove the exclusions and apply and enforce formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #126: SOLR-14920: add spotless and gjf (automatic code formatter) plumbing
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #126:
URL: https://github.com/apache/solr/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #126: SOLR-14920: add spotless and gjf (automatic code formatter) plumbing
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #126:
URL: https://github.com/apache/solr/pull/126#issuecomment-854483986
- [X] pull request branch is up to date with latest `origin/main`
- [X] `./gradlew spotlessCheck` passes
- [X] `./gradlew precommit` passes and as per https://github.com/apache/solr/blob/e8c0b705fcff69893f29015876aefe8e4317f143/gradle/validation/precommit.gradle#L33-L45 already includes the `spotlessCheck` that is now being defined via this pull request.
Based on "lazy consensus" will next proceed to merge the pull request here. But as always, post merge feedback is very welcome and worst case please do feel free to just revert the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org