[GitHub] [iceberg] RussellSpitzer commented on issue #1328: Checkstyle Improvements

[GitBox <gi...@apache.org>]

RussellSpitzer commented on issue #1328:
URL: https://github.com/apache/iceberg/issues/1328#issuecomment-673499586


   Yep we use this runtime called baseline
   
   https://github.com/apache/iceberg/blob/a6a511a98a6c679a7ac27c33832960ef8a4e88f1/build.gradle#L31
   
   Which has a ton of different checkstyle/findbug/linter things inside of it. They are only enabled on particular modules
   
   https://github.com/apache/iceberg/blob/a6a511a98a6c679a7ac27c33832960ef8a4e88f1/baseline.gradle#L34-L43
   
   Then we disable a bunch of the checks
   
   https://github.com/apache/iceberg/blob/a6a511a98a6c679a7ac27c33832960ef8a4e88f1/baseline.gradle#L62-L79
   
   ---
   
   The plugin here automatically pulls in versions of other style / static analysis tools. They are hardwired into the plugin but I believe we can override them in the build if we really want.
   
   See for example 
   
   https://github.com/palantir/gradle-baseline/blob/6dea8d29efaf1b0a5b9bcc7d7ebb51fe6b388b44/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineCheckstyle.java#L32
   
   --
   
   The Palantir package also does include some auto fix code which we are currently not using, or at least I haven't used them yet. 
   
   https://github.com/palantir/gradle-baseline#programmatic-application
   
   I'll take a look at your PR ASAP too. Anything to cleanup the project is good imho!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org