[I] traffic_ctl: apply --error-level to config reload results [trafficserver]

["brbzull0 (via GitHub)" <gi...@apache.org>]

brbzull0 opened a new issue, #13832:
URL: https://github.com/apache/trafficserver/issues/13832

   #13032 adds `traffic_ctl --error-level`, which sets the exit status of a JSONRPC handler failure from the most severe `data` entry. A `config reload` outcome is not a JSONRPC error. It comes back inside a successful result, as a task state plus task logs, so the level does not apply to it.
   
   Today:
   
   - `config reload --monitor` exits 2 when the task ends `fail` or `timeout` and 0 on `success`, whatever its log entries say. `--error-level=warn` cannot make a reload with warnings fail, and `--error-level=fatal` cannot relax a `fail`.
   - `config status` exits 0 for every task it prints, whatever its state.
   
   Each log entry already carries its `DiagsLevel` (`ConfigReloadResponse::LogEntry::level`), so both commands could grade a finished reload by its most severe entry.
   
   To decide:
   
   - the grade of a `fail` task that has no entry at or above the level, or no entries at all;
   - `timeout`, which has no severity of its own;
   - whether sub-task entries count, and the state-change entries (`DL_Undefined`);
   - `config status --count N`: one grade over every printed task, or the latest one only;
   - how `config status --min-level` (a display filter) and `--error-level` relate.
   
   Raised in https://github.com/apache/trafficserver/pull/13032#pullrequestreview-5420904089.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org