[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19931: Deprecate some functions in the experimental API

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #19931:
URL: https://github.com/apache/airflow/pull/19931#discussion_r760393787



##########
File path: airflow/api/client/local_client.py
##########
@@ -36,18 +38,20 @@ def delete_dag(self, dag_id):
         return f"Removed {count} record(s)"
 
     def get_pool(self, name):
-        the_pool = pool.get_pool(name=name)
+        the_pool = Pool.get_pool(pool_name=name)
+        if not the_pool:
+            raise PoolNotFound(f"Pool {name} not found")

Review comment:
       Previously, the `get_pool` experimental API raises PoolNotFound when the pool does not exist. Since I have moved it to the Pool model, I don't want it to raise hence raising not found here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org