You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/08/26 01:05:51 UTC
[GitHub] [tvm] tmoreau89 commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface
tmoreau89 commented on a change in pull request #8823:
URL: https://github.com/apache/tvm/pull/8823#discussion_r696212695
##########
File path: python/tvm/target/target.py
##########
@@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None):
return Target(" ".join(["opencl"] + opts))
-def hexagon(cpu_ver="v66", sim_args=None, llvm_args=None, hvx=128):
+def hexagon(cpu_ver="v66", **kwargs):
"""Returns a Hexagon target.
Parameters
----------
- cpu_ver : str
+ cpu_ver : str (default: "v66")
Review comment:
I think that's an interesting suggestion Chris - querying device attributes on Vulkan has helped a lot for codegen given the looseness of the Vulkan standard. In some ways I don't see this as too much of an usability burden, it's not unlike the `mcpu` option we have to pass in for llvm codegen when making sure to getting the best out of a given target x86 architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org