[jira] Resolved: (PDFBOX-422) Methods are marked as deprecated but they're effectively dead

["Brian Carrier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PDFBOX-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Carrier resolved PDFBOX-422.
----------------------------------

    Resolution: Fixed

Wrapper methods removed.

Sending        trunk/src/main/java/org/apache/pdfbox/util/PDFStreamEngine.java
Sending        trunk/src/main/java/org/apache/pdfbox/util/PDFText2HTML.java
Sending        trunk/src/main/java/org/apache/pdfbox/util/PDFTextStripper.java
Sending        trunk/src/main/java/org/apache/pdfbox/util/PDFTextStripperByArea.java
Transmitting file data ....
Committed revision 743530.

Note that wrapper methods existed for the following base methods:
PDFStreamEngine.showCharacter() -> PDFStreamEngine.processTextPosition()
PDFStreamEngine.showString() -> PDFStreamEngine.processEncodedText()
PDFTextStripper.flushText() -> PDFTextStripper.writePage()
PDFTextStripper.processsLineSeparator() -> PDFTextStripper.writeLineSeparator()
PDFTextStripper.processsWordSeparator() -> PDFTextStripper.writeWordSeparator()




> Methods are marked as deprecated but they're effectively dead
> -------------------------------------------------------------
>
>                 Key: PDFBOX-422
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-422
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Text extraction
>    Affects Versions: 0.8.0-incubator
>            Reporter: Gustavo Hexsel
>
> There are several methods on PDFTextStripper and PDFStreamEngine that are marked @deprecated, but they are not really used by the existing infrastructure anymore.
> This would be ok if such methods weren't callbacks.  In this case, it breaks pre-existing code, and prevents the compiler from letting you know the methods are not to be used anymore.
> Simply removing the methods would have been a much better solution in this case. 
> Example of said methods:
> org.apache.pdfbox.util.PDFTextStripper#processLineSeparator
> org.apache.pdfbox.util.PDFTextStripper#processWordSeparator
> org.apache.pdfbox.util.PDFTextStripper#writeCharacters

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.