You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/01/07 02:16:00 UTC
[jira] [Commented] (IMPALA-10424) Fix race on not_admitted_reason
in AdmissionController
[ https://issues.apache.org/jira/browse/IMPALA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260161#comment-17260161 ]
ASF subversion and git services commented on IMPALA-10424:
----------------------------------------------------------
Commit 799bc22d7077e1ce5a47cd4d74fbd18fe89f83e5 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=799bc22 ]
IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
QueueNode::not_admitted_reason can be accessed concurrently by the
coordinator thread that calls SubmitForAdmission and the admission
control dequeue loop thread.
This patch fixes this by ensuring that not_admitted_reason is only
accessed if 'admission_ctrl_lock_' is held.
Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Reviewed-on: http://gerrit.cloudera.org:8080/16926
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Fix race on not_admitted_reason in AdmissionController
> ------------------------------------------------------
>
> Key: IMPALA-10424
> URL: https://issues.apache.org/jira/browse/IMPALA-10424
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
>
> QueueNode::not_admitted_reason can be accessed concurrently by the coordinator thread that calls SubmitForAdmission and the admission control dequeue loop thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org